Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/07/2025 08:42, Peng Fan wrote:
>> +
>> +  interrupt-names:
>> +    minItems: 6
>> +    maxItems: 6
> 
> Ditto.
> 
> Do you need to define the list?


Did you read the entire binding? It reminds me Frank's comment as well -
instead of actually checking you just ask question which you would find
answer by yourselves if you really opened the code.

> 
>> +
>> +  qcom,qmp:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: Reference to the AOSS side-channel message RAM.
>> +
>> +  smd-edge: false
>> +
>> +  firmware-name:
>> +    $ref: /schemas/types.yaml#/definitions/string-array
>> +    minItems: 1
>> +    items:
>> +      - description: Firmware name of the Hexagon core
>> +      - description: Firmware name of the Hexagon Devicetree
>> +
>> +  memory-region:
>> +    minItems: 1
>> +    items:
>> +      - description: Memory region for core Firmware authentication
>> +      - description: Memory region for Devicetree Firmware authentication
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - memory-region
>> +
>> +allOf:
>> +  - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,milos-adsp-pas
>> +            - qcom,milos-cdsp-pas
>> +    then:
>> +      properties:
>> +        memory-region:
>> +          minItems: 2
>> +          maxItems: 2
>> +        firmware-name:
>> +          minItems: 2
>> +          maxItems: 2
> 
> Just keep minItems if maxItems is same value.


This is not a correct advice.


Best regards,
Krzysztof