[PATCH] pc104: move PC104 option to drivers/Kconfig

[PATCH] pc104: move PC104 option to drivers/Kconfig

[Randy Dunlap]

Put the PC104 kconfig option in drivers/Kconfig along with
other buses (AMBA, EISA, PCI, CXL, PCCard, & RapidIO).
This localizes PC104 with option bus kconfig options to make
it easier to find.

Fixes: ad90a3de9dd1 ("pc104: Introduce the PC104 Kconfig option")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: William Breathitt Gray <wbg@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

 drivers/Kconfig |    6 ++++++
 init/Kconfig    |    7 -------
 2 files changed, 6 insertions(+), 7 deletions(-)

--- linux-next-20250718.orig/drivers/Kconfig
+++ linux-next-20250718/drivers/Kconfig
@@ -10,6 +10,12 @@ source "drivers/cxl/Kconfig"
 source "drivers/pcmcia/Kconfig"
 source "drivers/rapidio/Kconfig"
 
+config PC104
+	bool "PC/104 support" if EXPERT
+	help
+	  Expose PC/104 form factor device drivers and options available for
+	  selection and configuration. Enable this option if your target
+	  machine has a PC/104 bus.
 
 source "drivers/base/Kconfig"
 
--- linux-next-20250718.orig/init/Kconfig
+++ linux-next-20250718/init/Kconfig
@@ -1914,13 +1914,6 @@ config CACHESTAT_SYSCALL
 
 	  If unsure say Y here.
 
-config PC104
-	bool "PC/104 support" if EXPERT
-	help
-	  Expose PC/104 form factor device drivers and options available for
-	  selection and configuration. Enable this option if your target
-	  machine has a PC/104 bus.
-
 config KALLSYMS
 	bool "Load all symbols for debugging/ksymoops" if EXPERT
 	default y

Re: [PATCH] pc104: move PC104 option to drivers/Kconfig

[William Breathitt Gray]

On Sun, Jul 20, 2025 at 11:26:30PM -0700, Randy Dunlap wrote:
> Put the PC104 kconfig option in drivers/Kconfig along with
> other buses (AMBA, EISA, PCI, CXL, PCCard, & RapidIO).
> This localizes PC104 with option bus kconfig options to make
> it easier to find.
> 
> Fixes: ad90a3de9dd1 ("pc104: Introduce the PC104 Kconfig option")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

This isn't really a bugfix, so it doesn't need a Fixes tag, does it?

Regardless, I think drivers/Kconfig makes sense for this kconfig option,
so here's my Ack.

Acked-by: William Breathitt Gray <wbg@kernel.org>

Re: [PATCH] pc104: move PC104 option to drivers/Kconfig

[Randy Dunlap]

On 7/21/25 8:24 AM, William Breathitt Gray wrote:
> On Sun, Jul 20, 2025 at 11:26:30PM -0700, Randy Dunlap wrote:
>> Put the PC104 kconfig option in drivers/Kconfig along with
>> other buses (AMBA, EISA, PCI, CXL, PCCard, & RapidIO).
>> This localizes PC104 with option bus kconfig options to make
>> it easier to find.
>>
>> Fixes: ad90a3de9dd1 ("pc104: Introduce the PC104 Kconfig option")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> This isn't really a bugfix, so it doesn't need a Fixes tag, does it?

I agree. Sometimes maintainers (or their bots) want a Fixes: tag
on almost anything that isn't new code. :(

I'll remove it and send a v2 with your Ack.

Thanks.

> 
> Regardless, I think drivers/Kconfig makes sense for this kconfig option,
> so here's my Ack.
> 
> Acked-by: William Breathitt Gray <wbg@kernel.org>

-- 
~Randy