From: Yu Kuai <yukuai@kernel.org>
To: corbet@lwn.net, agk@redhat.co, snitzer@kernel.org,
mpatocka@redhat.com, hch@lst.de, song@kernel.org, hare@suse.de
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@lists.linux.dev, linux-raid@vger.kernel.org,
yukuai3@huawei.com, yangerkun@huawei.com, yi.zhang@huawei.com,
johnny.chenyi@huawei.com
Subject: [PATCH v4 10/11] md/md-bitmap: make method bitmap_ops->daemon_work optional
Date: Tue, 22 Jul 2025 01:15:56 +0800 [thread overview]
Message-ID: <20250721171557.34587-11-yukuai@kernel.org> (raw)
In-Reply-To: <20250721171557.34587-1-yukuai@kernel.org>
From: Yu Kuai <yukuai3@huawei.com>
daemon_work() will be called by daemon thread, on the one hand, daemon
thread doesn't have strict wake-up time; on the other hand, too much
work are put to daemon thread, like handle sync IO, handle failed
or specail normal IO, handle recovery, and so on. Hence daemon thread
may be too busy to clear dirty bits in time.
Make bitmap_ops->daemon_work() optional and following patches will use
separate async work to clear dirty bits for the new bitmap.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index ab4799e2a0bd..fcb0dfcf1e84 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9887,7 +9887,7 @@ static void unregister_sync_thread(struct mddev *mddev)
*/
void md_check_recovery(struct mddev *mddev)
{
- if (md_bitmap_enabled(mddev, false))
+ if (md_bitmap_enabled(mddev, false) && mddev->bitmap_ops->daemon_work)
mddev->bitmap_ops->daemon_work(mddev);
if (signal_pending(current)) {
--
2.43.0
next prev parent reply other threads:[~2025-07-21 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 17:15 [PATCH v4 00/11] md/llbitmap: md/md-llbitmap: introduce a new lockless bitmap Yu Kuai
2025-07-21 17:15 ` [PATCH v4 01/11] md: add a new parameter 'offset' to md_super_write() Yu Kuai
2025-07-21 17:15 ` [PATCH v4 02/11] md: factor out a helper raid_is_456() Yu Kuai
2025-07-21 17:15 ` [PATCH v4 03/11] md/md-bitmap: support discard for bitmap ops Yu Kuai
2025-07-21 17:15 ` [PATCH v4 04/11] md: add a new mddev field 'bitmap_id' Yu Kuai
2025-07-21 17:15 ` [PATCH v4 05/11] md/md-bitmap: add a new sysfs api bitmap_type Yu Kuai
2025-07-21 17:15 ` [PATCH v4 06/11] md/md-bitmap: delay registration of bitmap_ops until creating bitmap Yu Kuai
2025-07-22 6:07 ` Hannes Reinecke
2025-07-21 17:15 ` [PATCH v4 07/11] md/md-bitmap: add a new method skip_sync_blocks() in bitmap_operations Yu Kuai
2025-07-21 17:15 ` [PATCH v4 08/11] md/md-bitmap: add a new method blocks_synced() " Yu Kuai
2025-07-21 17:15 ` [PATCH v4 09/11] md: add a new recovery_flag MD_RECOVERY_LAZY_RECOVER Yu Kuai
2025-07-21 17:15 ` Yu Kuai [this message]
2025-07-21 17:15 ` [PATCH v4 11/11] md/md-llbitmap: introduce new lockless bitmap Yu Kuai
2025-08-01 2:00 ` Yu Kuai
2025-07-22 8:29 ` [PATCH v4 00/11] md/llbitmap: md/md-llbitmap: introduce a " Li Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250721171557.34587-11-yukuai@kernel.org \
--to=yukuai@kernel.org \
--cc=agk@redhat.co \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=johnny.chenyi@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®