mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai@kernel.org>
To: corbet@lwn.net, agk@redhat.co, snitzer@kernel.org,
	mpatocka@redhat.com, hch@lst.de, song@kernel.org, hare@suse.de
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	dm-devel@lists.linux.dev, linux-raid@vger.kernel.org,
	yukuai3@huawei.com, yangerkun@huawei.com, yi.zhang@huawei.com,
	johnny.chenyi@huawei.com, Xiao Ni <xni@redhat.com>
Subject: [PATCH v4 07/11] md/md-bitmap: add a new method skip_sync_blocks() in bitmap_operations
Date: Tue, 22 Jul 2025 01:15:53 +0800	[thread overview]
Message-ID: <20250721171557.34587-8-yukuai@kernel.org> (raw)
In-Reply-To: <20250721171557.34587-1-yukuai@kernel.org>

From: Yu Kuai <yukuai3@huawei.com>

This method is used to check if blocks can be skipped before calling
into pers->sync_request(), llbitmap will use this method to skip
resync for unwritten/clean data blocks, and recovery/check/repair for
unwritten data blocks;

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Xiao Ni <xni@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
 drivers/md/md-bitmap.h | 1 +
 drivers/md/md.c        | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/drivers/md/md-bitmap.h b/drivers/md/md-bitmap.h
index 8616ced49077..95453696c68e 100644
--- a/drivers/md/md-bitmap.h
+++ b/drivers/md/md-bitmap.h
@@ -89,6 +89,7 @@ struct bitmap_operations {
 	md_bitmap_fn *start_discard;
 	md_bitmap_fn *end_discard;
 
+	sector_t (*skip_sync_blocks)(struct mddev *mddev, sector_t offset);
 	bool (*start_sync)(struct mddev *mddev, sector_t offset,
 			   sector_t *blocks, bool degraded);
 	void (*end_sync)(struct mddev *mddev, sector_t offset, sector_t *blocks);
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 744cac10506b..71f39f9ce9ca 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9396,6 +9396,12 @@ void md_do_sync(struct md_thread *thread)
 		if (test_bit(MD_RECOVERY_INTR, &mddev->recovery))
 			break;
 
+		if (mddev->bitmap_ops && mddev->bitmap_ops->skip_sync_blocks) {
+			sectors = mddev->bitmap_ops->skip_sync_blocks(mddev, j);
+			if (sectors)
+				goto update;
+		}
+
 		sectors = mddev->pers->sync_request(mddev, j, max_sectors,
 						    &skipped);
 		if (sectors == 0) {
@@ -9411,6 +9417,7 @@ void md_do_sync(struct md_thread *thread)
 		if (test_bit(MD_RECOVERY_INTR, &mddev->recovery))
 			break;
 
+update:
 		j += sectors;
 		if (j > max_sectors)
 			/* when skipping, extra large numbers can be returned. */
-- 
2.43.0


  parent reply	other threads:[~2025-07-21 17:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21 17:15 [PATCH v4 00/11] md/llbitmap: md/md-llbitmap: introduce a new lockless bitmap Yu Kuai
2025-07-21 17:15 ` [PATCH v4 01/11] md: add a new parameter 'offset' to md_super_write() Yu Kuai
2025-07-21 17:15 ` [PATCH v4 02/11] md: factor out a helper raid_is_456() Yu Kuai
2025-07-21 17:15 ` [PATCH v4 03/11] md/md-bitmap: support discard for bitmap ops Yu Kuai
2025-07-21 17:15 ` [PATCH v4 04/11] md: add a new mddev field 'bitmap_id' Yu Kuai
2025-07-21 17:15 ` [PATCH v4 05/11] md/md-bitmap: add a new sysfs api bitmap_type Yu Kuai
2025-07-21 17:15 ` [PATCH v4 06/11] md/md-bitmap: delay registration of bitmap_ops until creating bitmap Yu Kuai
2025-07-22  6:07   ` Hannes Reinecke
2025-07-21 17:15 ` Yu Kuai [this message]
2025-07-21 17:15 ` [PATCH v4 08/11] md/md-bitmap: add a new method blocks_synced() in bitmap_operations Yu Kuai
2025-07-21 17:15 ` [PATCH v4 09/11] md: add a new recovery_flag MD_RECOVERY_LAZY_RECOVER Yu Kuai
2025-07-21 17:15 ` [PATCH v4 10/11] md/md-bitmap: make method bitmap_ops->daemon_work optional Yu Kuai
2025-07-21 17:15 ` [PATCH v4 11/11] md/md-llbitmap: introduce new lockless bitmap Yu Kuai
2025-08-01  2:00   ` Yu Kuai
2025-07-22  8:29 ` [PATCH v4 00/11] md/llbitmap: md/md-llbitmap: introduce a " Li Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250721171557.34587-8-yukuai@kernel.org \
    --to=yukuai@kernel.org \
    --cc=agk@redhat.co \
    --cc=corbet@lwn.net \
    --cc=dm-devel@lists.linux.dev \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=johnny.chenyi@huawei.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®