From: Jie Gan <jie.gan@oss.qualcomm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
Jinlong Mao <jinlong.mao@oss.qualcomm.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Jie Gan <quic_jiegan@quicinc.com>
Subject: [PATCH v4 09/10] coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops
Date: Fri, 25 Jul 2025 18:08:05 +0800 [thread overview]
Message-ID: <20250725100806.1157-10-jie.gan@oss.qualcomm.com> (raw)
In-Reply-To: <20250725100806.1157-1-jie.gan@oss.qualcomm.com>
Add code logic to invoke byte-cntr's read_ops if the byte-cntr
is enabled.
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
---
.../hwtracing/coresight/coresight-tmc-core.c | 48 ++++++++++++++++++-
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
index f668047c5df4..671ae4542f6a 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-core.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
@@ -228,15 +228,41 @@ static int tmc_prepare_crashdata(struct tmc_drvdata *drvdata)
return 0;
}
+static const struct tmc_read_ops *tmc_qcom_byte_cntr_in_use(struct tmc_drvdata *drvdata,
+ bool *in_use)
+{
+ struct tmc_read_ops *byte_cntr_read_ops;
+ struct coresight_device *helper;
+
+ helper = coresight_get_helper(drvdata->csdev, CORESIGHT_DEV_SUBTYPE_HELPER_CTCU);
+ if (helper)
+ *in_use = helper_ops(helper)->qcom_byte_cntr_in_use(drvdata->csdev,
+ (void **)&byte_cntr_read_ops);
+
+ if (*in_use)
+ return byte_cntr_read_ops;
+
+ return NULL;
+}
+
static int tmc_read_prepare(struct tmc_drvdata *drvdata)
{
+ const struct tmc_read_ops *byte_cntr_read_ops;
+ bool in_use = false;
int ret = 0;
+ byte_cntr_read_ops = tmc_qcom_byte_cntr_in_use(drvdata, &in_use);
+ if (in_use) {
+ ret = byte_cntr_read_ops->read_prepare(drvdata);
+ goto out;
+ }
+
if (drvdata->read_ops)
ret = drvdata->read_ops->read_prepare(drvdata);
else
ret = -EINVAL;
+out:
if (!ret)
dev_dbg(&drvdata->csdev->dev, "TMC read start\n");
@@ -245,13 +271,22 @@ static int tmc_read_prepare(struct tmc_drvdata *drvdata)
static int tmc_read_unprepare(struct tmc_drvdata *drvdata)
{
+ const struct tmc_read_ops *byte_cntr_read_ops;
+ bool in_use = false;
int ret = 0;
+ byte_cntr_read_ops = tmc_qcom_byte_cntr_in_use(drvdata, &in_use);
+ if (in_use) {
+ ret = byte_cntr_read_ops->read_unprepare(drvdata);
+ goto out;
+ }
+
if (drvdata->read_ops)
ret = drvdata->read_ops->read_unprepare(drvdata);
else
ret = -EINVAL;
+out:
if (!ret)
dev_dbg(&drvdata->csdev->dev, "TMC read end\n");
@@ -277,6 +312,13 @@ static int tmc_open(struct inode *inode, struct file *file)
static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos, size_t len,
char **bufpp)
{
+ const struct tmc_read_ops *byte_cntr_read_ops;
+ bool in_use = false;
+
+ byte_cntr_read_ops = tmc_qcom_byte_cntr_in_use(drvdata, &in_use);
+ if (in_use)
+ return byte_cntr_read_ops->get_trace_data(drvdata, pos, len, bufpp);
+
if (drvdata->read_ops)
return drvdata->read_ops->get_trace_data(drvdata, pos, len, bufpp);
@@ -300,7 +342,11 @@ static ssize_t tmc_read(struct file *file, char __user *data, size_t len,
return -EFAULT;
}
- *ppos += actual;
+ if (drvdata->reading_node)
+ drvdata->reading_node->pos += actual;
+ else
+ *ppos += actual;
+
dev_dbg(&drvdata->csdev->dev, "%zu bytes copied\n", actual);
return actual;
--
2.34.1
next prev parent reply other threads:[~2025-07-25 10:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 10:07 [PATCH v4 00/10] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2025-07-25 10:07 ` [PATCH v4 01/10] coresight: core: Refactoring ctcu_get_active_port and make it generic Jie Gan
2025-08-05 9:55 ` Mike Leach
2025-07-25 10:07 ` [PATCH v4 02/10] coresight: core: add a new API to retrieve the helper device Jie Gan
2025-08-05 9:57 ` Mike Leach
2025-07-25 10:07 ` [PATCH v4 03/10] coresight: tmc: add etr_buf_list to store allocated etr_buf Jie Gan
2025-08-05 10:15 ` Mike Leach
2025-08-06 0:32 ` Jie Gan
2025-07-25 10:08 ` [PATCH v4 04/10] coresight: tmc: add create/delete functions for etr_buf_node Jie Gan
2025-08-05 10:27 ` Mike Leach
2025-08-06 0:45 ` Jie Gan
2025-07-25 10:08 ` [PATCH v4 05/10] coresight: tmc: Introduce tmc_read_ops to wrap read operations Jie Gan
2025-08-05 10:55 ` Mike Leach
2025-08-06 6:30 ` Jie Gan
2025-08-06 6:56 ` Mike Leach
2025-07-25 10:08 ` [PATCH v4 06/10] dt-bindings: arm: add an interrupt property for Coresight CTCU Jie Gan
2025-07-25 10:08 ` [PATCH v4 07/10] coresight: ctcu: enable byte-cntr for TMC ETR devices Jie Gan
2025-07-25 10:08 ` [PATCH v4 08/10] coresight: add a new function in helper_ops Jie Gan
2025-08-05 12:28 ` Mike Leach
2025-08-05 12:30 ` Mike Leach
2025-08-06 0:35 ` Jie Gan
2025-08-06 8:32 ` Jie Gan
2025-07-25 10:08 ` Jie Gan [this message]
2025-07-25 10:08 ` [PATCH v4 10/10] arm64: dts: qcom: sa8775p: Add interrupts to CTCU device Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725100806.1157-10-jie.gan@oss.qualcomm.com \
--to=jie.gan@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=jinlong.mao@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®