From: Jie Gan <jie.gan@oss.qualcomm.com>
To: Mike Leach <mike.leach@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
Jinlong Mao <jinlong.mao@oss.qualcomm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Jie Gan <quic_jiegan@quicinc.com>
Subject: Re: [PATCH v4 08/10] coresight: add a new function in helper_ops
Date: Wed, 6 Aug 2025 08:35:24 +0800 [thread overview]
Message-ID: <40c8c2d0-1ac3-4944-b509-d23f21687476@oss.qualcomm.com> (raw)
In-Reply-To: <CAJ9a7Vi8qpHH2SjmKNjgeY4gdRXY9wnQXhkjN71EcbYSKqayuw@mail.gmail.com>
On 8/5/2025 8:30 PM, Mike Leach wrote:
> Hi,
>
> On Fri, 25 Jul 2025 at 11:08, Jie Gan <jie.gan@oss.qualcomm.com> wrote:
>>
>> Add a new function to identifiy whether the byte-cntr function is
>> enabled or not in helper_ops.
>>
>> The byte-cntr's read_ops is expected if the byte-cntr is enabled when
>> the user try to read trace data via sysfs node.
>>
>> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
>> ---
>> .../hwtracing/coresight/coresight-ctcu-core.c | 35 +++++++++++++++++++
>> include/linux/coresight.h | 3 ++
>> 2 files changed, 38 insertions(+)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-ctcu-core.c b/drivers/hwtracing/coresight/coresight-ctcu-core.c
>> index 8fc08e42187e..dec911980939 100644
>> --- a/drivers/hwtracing/coresight/coresight-ctcu-core.c
>> +++ b/drivers/hwtracing/coresight/coresight-ctcu-core.c
>> @@ -234,9 +234,44 @@ static int ctcu_disable(struct coresight_device *csdev, void *data)
>> return ctcu_set_etr_traceid(csdev, path, false);
>> }
>>
>> +static bool ctcu_qcom_byte_cntr_in_use(struct coresight_device *csdev,
>> + void **data)
>> +{
>> + struct ctcu_byte_cntr *byte_cntr_data;
>> + struct coresight_device *helper;
>> + struct ctcu_drvdata *drvdata;
>> + int port;
>> +
>> + if (!csdev)
>> + return false;
>> +
>> + helper = coresight_get_helper(csdev, CORESIGHT_DEV_SUBTYPE_HELPER_CTCU);
>> + if (!helper)
>> + return false;
>> +
>> + port = coresight_get_in_port_dest(csdev, helper);
>> + if (port < 0)
>> + return false;
>> +
>> + drvdata = dev_get_drvdata(helper->dev.parent);
>> + /* Something wrong when initialize byte_cntr_read_ops */
>> + if (!drvdata->byte_cntr_read_ops)
>> + return false;
>> +
>> + byte_cntr_data = &drvdata->byte_cntr_data[port];
>> + /* Return the pointer of the ctcu_drvdata if byte-cntr has enabled */
>> + if (byte_cntr_data && byte_cntr_data->thresh_val) {
>> + *data = (void *)drvdata->byte_cntr_read_ops;
>> + return true;
>> + }
>> +
>> + return false;
>> +}
>> +
>> static const struct coresight_ops_helper ctcu_helper_ops = {
>> .enable = ctcu_enable,
>> .disable = ctcu_disable,
>> + .qcom_byte_cntr_in_use = ctcu_qcom_byte_cntr_in_use,
>
> These ops structures are for generic functions used throughout the
> devices. Do not put this function here.
>
> This is a specific ctcu helper. Make it external to the file and
> declare it in coresight-ctcu.h
Will address the comment in next version.
Thanks,
Jie
>
> Mike
>
>> };
>>
>> static const struct coresight_ops ctcu_ops = {
>> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
>> index 4ac65c68bbf4..b5f052854b08 100644
>> --- a/include/linux/coresight.h
>> +++ b/include/linux/coresight.h
>> @@ -419,11 +419,14 @@ struct coresight_ops_source {
>> *
>> * @enable : Enable the device
>> * @disable : Disable the device
>> + * @qcom_byte_cntr_in_use: check whether the byte-cntr is enabled.
>> */
>> struct coresight_ops_helper {
>> int (*enable)(struct coresight_device *csdev, enum cs_mode mode,
>> void *data);
>> int (*disable)(struct coresight_device *csdev, void *data);
>> + bool (*qcom_byte_cntr_in_use)(struct coresight_device *csdev,
>> + void **data);
>> };
>>
>>
>> --
>> 2.34.1
>>
>
>
next prev parent reply other threads:[~2025-08-06 0:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 10:07 [PATCH v4 00/10] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2025-07-25 10:07 ` [PATCH v4 01/10] coresight: core: Refactoring ctcu_get_active_port and make it generic Jie Gan
2025-08-05 9:55 ` Mike Leach
2025-07-25 10:07 ` [PATCH v4 02/10] coresight: core: add a new API to retrieve the helper device Jie Gan
2025-08-05 9:57 ` Mike Leach
2025-07-25 10:07 ` [PATCH v4 03/10] coresight: tmc: add etr_buf_list to store allocated etr_buf Jie Gan
2025-08-05 10:15 ` Mike Leach
2025-08-06 0:32 ` Jie Gan
2025-07-25 10:08 ` [PATCH v4 04/10] coresight: tmc: add create/delete functions for etr_buf_node Jie Gan
2025-08-05 10:27 ` Mike Leach
2025-08-06 0:45 ` Jie Gan
2025-07-25 10:08 ` [PATCH v4 05/10] coresight: tmc: Introduce tmc_read_ops to wrap read operations Jie Gan
2025-08-05 10:55 ` Mike Leach
2025-08-06 6:30 ` Jie Gan
2025-08-06 6:56 ` Mike Leach
2025-07-25 10:08 ` [PATCH v4 06/10] dt-bindings: arm: add an interrupt property for Coresight CTCU Jie Gan
2025-07-25 10:08 ` [PATCH v4 07/10] coresight: ctcu: enable byte-cntr for TMC ETR devices Jie Gan
2025-07-25 10:08 ` [PATCH v4 08/10] coresight: add a new function in helper_ops Jie Gan
2025-08-05 12:28 ` Mike Leach
2025-08-05 12:30 ` Mike Leach
2025-08-06 0:35 ` Jie Gan [this message]
2025-08-06 8:32 ` Jie Gan
2025-07-25 10:08 ` [PATCH v4 09/10] coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops Jie Gan
2025-07-25 10:08 ` [PATCH v4 10/10] arm64: dts: qcom: sa8775p: Add interrupts to CTCU device Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40c8c2d0-1ac3-4944-b509-d23f21687476@oss.qualcomm.com \
--to=jie.gan@oss.qualcomm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=jinlong.mao@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®