* [PATCH] Fix comment ordering.
@ 2025-07-26 0:40 Blake Jones
2025-07-26 0:45 ` Ian Rogers
2025-07-26 22:36 ` Namhyung Kim
0 siblings, 2 replies; 3+ messages in thread
From: Blake Jones @ 2025-07-26 0:40 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim
Cc: Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, Kan Liang, Blake Jones, Collin Funk, James Clark,
linux-perf-users, linux-kernel, bpf
Commit edf2cadf01e8f2620af25b337d15ebc584911b46 ("perf test: add test for
BPF metadata collection") overlooked a behavior of "perf test list",
causing it to print "SPDX-License-Identifier: GPL-2.0" as a description for
that test. This reorders the comments to fix that issue.
Signed-off-by: Blake Jones <blakejones@google.com>
---
tools/perf/tests/shell/test_bpf_metadata.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/shell/test_bpf_metadata.sh b/tools/perf/tests/shell/test_bpf_metadata.sh
index bc9aef161664..69e3c2055134 100755
--- a/tools/perf/tests/shell/test_bpf_metadata.sh
+++ b/tools/perf/tests/shell/test_bpf_metadata.sh
@@ -1,7 +1,7 @@
#!/bin/bash
-# SPDX-License-Identifier: GPL-2.0
+# BPF metadata collection test
#
-# BPF metadata collection test.
+# SPDX-License-Identifier: GPL-2.0
set -e
--
2.50.1.470.g6ba607880d-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix comment ordering.
2025-07-26 0:40 [PATCH] Fix comment ordering Blake Jones
@ 2025-07-26 0:45 ` Ian Rogers
2025-07-26 22:36 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Ian Rogers @ 2025-07-26 0:45 UTC (permalink / raw)
To: Blake Jones
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Adrian Hunter, Kan Liang, Collin Funk, James Clark,
linux-perf-users, linux-kernel, bpf
On Fri, Jul 25, 2025 at 5:40 PM Blake Jones <blakejones@google.com> wrote:
>
> Commit edf2cadf01e8f2620af25b337d15ebc584911b46 ("perf test: add test for
> BPF metadata collection") overlooked a behavior of "perf test list",
> causing it to print "SPDX-License-Identifier: GPL-2.0" as a description for
> that test. This reorders the comments to fix that issue.
>
> Signed-off-by: Blake Jones <blakejones@google.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks!
Ian
> ---
> tools/perf/tests/shell/test_bpf_metadata.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/test_bpf_metadata.sh b/tools/perf/tests/shell/test_bpf_metadata.sh
> index bc9aef161664..69e3c2055134 100755
> --- a/tools/perf/tests/shell/test_bpf_metadata.sh
> +++ b/tools/perf/tests/shell/test_bpf_metadata.sh
> @@ -1,7 +1,7 @@
> #!/bin/bash
> -# SPDX-License-Identifier: GPL-2.0
> +# BPF metadata collection test
> #
> -# BPF metadata collection test.
> +# SPDX-License-Identifier: GPL-2.0
>
> set -e
>
> --
> 2.50.1.470.g6ba607880d-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix comment ordering.
2025-07-26 0:40 [PATCH] Fix comment ordering Blake Jones
2025-07-26 0:45 ` Ian Rogers
@ 2025-07-26 22:36 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2025-07-26 22:36 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Blake Jones
Cc: Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, Kan Liang, Collin Funk, James Clark,
linux-perf-users, linux-kernel, bpf
On Fri, 25 Jul 2025 17:40:23 -0700, Blake Jones wrote:
> Commit edf2cadf01e8f2620af25b337d15ebc584911b46 ("perf test: add test for
> BPF metadata collection") overlooked a behavior of "perf test list",
> causing it to print "SPDX-License-Identifier: GPL-2.0" as a description for
> that test. This reorders the comments to fix that issue.
>
>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-26 22:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-26 0:40 [PATCH] Fix comment ordering Blake Jones
2025-07-26 0:45 ` Ian Rogers
2025-07-26 22:36 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®