From: Ao Sun <aosun718@gmail.com>
To: linux@roeck-us.net, matthias.bgg@gmail.com,
p.zabel@pengutronix.de, wim@linux-watchdog.org
Cc: linux-kernel@vger.kernel.org, geng.sun@transsion.com,
Ao Sun <aosun718@gmail.com>, Jiazi Li <jqqlijiazi@gmail.com>,
"peixuan . qiu" <peixuan.qiu@transsion.com>
Subject: [PATCH v2] watchdog: mtk_wdt: Use NOIRQ_SYSTEM_SLEEP_PM_OPS()
Date: Thu, 31 Jul 2025 11:31:36 +0800 [thread overview]
Message-ID: <20250731033136.3914-1-aosun718@gmail.com> (raw)
In-Reply-To: <2bf292d6-0f51-473c-bd44-f129a0b2a7ab@roeck-us.net>
During the device resume process, an interrupt storm occurs after
interrupts are enabled, preventing the watchdog device from being
resumed and functioning.
To ensure that the watchdog is resumed and executed before interrupts
are enabled, Use NOIRQ_SYSTEM_SLEEP_PM_OPS().
Signed-off-by: Jiazi Li <jqqlijiazi@gmail.com>
Signed-off-by: peixuan.qiu <peixuan.qiu@transsion.com>
Signed-off-by: Ao Sun <aosun718@gmail.com>
---
Changes in v2:
- remove extra space, and align multiple lines.
---
drivers/watchdog/mtk_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index d6a6393f609d..7dc53409cf99 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -327,8 +327,8 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);
static const struct dev_pm_ops mtk_wdt_pm_ops = {
- SET_SYSTEM_SLEEP_PM_OPS(mtk_wdt_suspend,
- mtk_wdt_resume)
+ SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mtk_wdt_suspend,
+ mtk_wdt_resume)
};
static struct platform_driver mtk_wdt_driver = {
--
2.34.1
next prev parent reply other threads:[~2025-07-31 3:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 3:51 [PATCH] " Ao Sun
2025-07-29 14:00 ` Guenter Roeck
2025-07-31 3:31 ` Ao Sun [this message]
2025-07-31 13:39 ` [PATCH v2] " Guenter Roeck
2025-08-04 6:11 ` [PATCH v3] " Ao Sun
2025-08-04 10:31 ` Matthias Brugger
2026-03-16 10:19 ` [PATCH RESEND] watchdog: mtk_wdt: Use DEFINE_NOIRQ_DEV_PM_OPS() Ao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731033136.3914-1-aosun718@gmail.com \
--to=aosun718@gmail.com \
--cc=geng.sun@transsion.com \
--cc=jqqlijiazi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=peixuan.qiu@transsion.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®