mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ao Sun <aosun718@gmail.com>
To: matthias.bgg@gmail.com, p.zabel@pengutronix.de, wim@linux-watchdog.org
Cc: aosun718@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] watchdog: mtk_wdt: Use DEFINE_NOIRQ_DEV_PM_OPS()
Date: Mon, 16 Mar 2026 18:19:06 +0800	[thread overview]
Message-ID: <20260316101906.1037-1-aosun718@gmail.com> (raw)
In-Reply-To: <39707662-e53d-4f95-9e3b-6517142efc6c@gmail.com>

During the device resume process, an interrupt storm occurs after
interrupts are enabled, preventing the watchdog device from being
resumed and functioning.

To ensure that the watchdog is resumed and executed before interrupts
are enabled, Use DEFINE_NOIRQ_DEV_PM_OPS()

Signed-off-by: Ao Sun <aosun718@gmail.com>
---
Changes in v3:
 - correct the Signed-off-by.
Changes in v2:
 - remove extra space, and align multiple lines.
---
 drivers/watchdog/mtk_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
index 91d110646e16..c3527bae22af 100644
--- a/drivers/watchdog/mtk_wdt.c
+++ b/drivers/watchdog/mtk_wdt.c
@@ -507,8 +507,8 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
 };
 MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);
 
-static DEFINE_SIMPLE_DEV_PM_OPS(mtk_wdt_pm_ops,
-				mtk_wdt_suspend, mtk_wdt_resume);
+static DEFINE_NOIRQ_DEV_PM_OPS(mtk_wdt_pm_ops,
+			       mtk_wdt_suspend, mtk_wdt_resume);
 
 static struct platform_driver mtk_wdt_driver = {
 	.probe		= mtk_wdt_probe,
-- 
2.34.1


      reply	other threads:[~2026-03-16 10:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  3:51 [PATCH] watchdog: mtk_wdt: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() Ao Sun
2025-07-29 14:00 ` Guenter Roeck
2025-07-31  3:31   ` [PATCH v2] " Ao Sun
2025-07-31 13:39     ` Guenter Roeck
2025-08-04  6:11       ` [PATCH v3] " Ao Sun
2025-08-04 10:31         ` Matthias Brugger
2026-03-16 10:19           ` Ao Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316101906.1037-1-aosun718@gmail.com \
    --to=aosun718@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®