From: dikshakdevgan@gmail.com
To: rafael@kernel.org, robert.moore@intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: Diksha Kumari <dkdevgan@outlook.com>
Subject: [PATCH] acpi: remove unnecessary paranthesis from return
Date: Sun, 3 Aug 2025 17:08:20 +0530 [thread overview]
Message-ID: <20250803113820.16578-1-dikshakdevgan@gmail.com> (raw)
From: Diksha Kumari <dkdevgan@outlook.com>
checkpatch.pl is generating a warning when return value is
enclosed in paranthesis. Remove the paranthesis to improve
code readability.
Signed-off-by: Diksha Kumari <dkdevgan@outlook.com>
---
drivers/acpi/acpica/dbconvert.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/acpi/acpica/dbconvert.c b/drivers/acpi/acpica/dbconvert.c
index 8dbab6932049..7995c1578522 100644
--- a/drivers/acpi/acpica/dbconvert.c
+++ b/drivers/acpi/acpica/dbconvert.c
@@ -32,7 +32,7 @@ acpi_status acpi_db_hex_char_to_value(int hex_char, u8 *return_value)
/* Digit must be ascii [0-9a-fA-F] */
if (!isxdigit(hex_char)) {
- return (AE_BAD_HEX_CONSTANT);
+ return AE_BAD_HEX_CONSTANT;
}
if (hex_char <= 0x39) {
@@ -42,7 +42,7 @@ acpi_status acpi_db_hex_char_to_value(int hex_char, u8 *return_value)
}
*return_value = value;
- return (AE_OK);
+ return AE_OK;
}
/*******************************************************************************
@@ -69,18 +69,18 @@ static acpi_status acpi_db_hex_byte_to_binary(char *hex_byte, u8 *return_value)
status = acpi_db_hex_char_to_value(hex_byte[0], &local0);
if (ACPI_FAILURE(status)) {
- return (status);
+ return status;
}
/* Low byte */
status = acpi_db_hex_char_to_value(hex_byte[1], &local1);
if (ACPI_FAILURE(status)) {
- return (status);
+ return status;
}
*return_value = (u8)((local0 << 4) | local1);
- return (AE_OK);
+ return AE_OK;
}
/*******************************************************************************
@@ -123,7 +123,7 @@ acpi_db_convert_to_buffer(char *string, union acpi_object *object)
buffer = ACPI_ALLOCATE(length);
if (!buffer) {
- return (AE_NO_MEMORY);
+ return AE_NO_MEMORY;
}
/* Convert the command line bytes to the buffer */
@@ -132,7 +132,7 @@ acpi_db_convert_to_buffer(char *string, union acpi_object *object)
status = acpi_db_hex_byte_to_binary(&string[i], &buffer[j]);
if (ACPI_FAILURE(status)) {
ACPI_FREE(buffer);
- return (status);
+ return status;
}
j++;
@@ -145,7 +145,7 @@ acpi_db_convert_to_buffer(char *string, union acpi_object *object)
object->type = ACPI_TYPE_BUFFER;
object->buffer.pointer = buffer;
object->buffer.length = length;
- return (AE_OK);
+ return AE_OK;
}
/*******************************************************************************
@@ -175,7 +175,7 @@ acpi_status acpi_db_convert_to_package(char *string, union acpi_object *object)
ACPI_ALLOCATE_ZEROED(DB_DEFAULT_PKG_ELEMENTS *
sizeof(union acpi_object));
if (!elements)
- return (AE_NO_MEMORY);
+ return AE_NO_MEMORY;
this = string;
for (i = 0; i < (DB_DEFAULT_PKG_ELEMENTS - 1); i++) {
@@ -190,7 +190,7 @@ acpi_status acpi_db_convert_to_package(char *string, union acpi_object *object)
if (ACPI_FAILURE(status)) {
acpi_db_delete_objects(i + 1, elements);
ACPI_FREE(elements);
- return (status);
+ return status;
}
this = next;
@@ -199,7 +199,7 @@ acpi_status acpi_db_convert_to_package(char *string, union acpi_object *object)
object->type = ACPI_TYPE_PACKAGE;
object->package.count = i;
object->package.elements = elements;
- return (AE_OK);
+ return AE_OK;
}
/*******************************************************************************
@@ -251,7 +251,7 @@ acpi_db_convert_to_object(acpi_object_type type,
break;
}
- return (status);
+ return status;
}
/*******************************************************************************
@@ -273,7 +273,7 @@ u8 *acpi_db_encode_pld_buffer(struct acpi_pld_info *pld_info)
buffer = ACPI_ALLOCATE_ZEROED(ACPI_PLD_BUFFER_SIZE);
if (!buffer) {
- return (NULL);
+ return NULL;
}
/* First 32 bits */
@@ -331,7 +331,7 @@ u8 *acpi_db_encode_pld_buffer(struct acpi_pld_info *pld_info)
ACPI_MOVE_32_TO_32(&buffer[4], &dword);
}
- return (ACPI_CAST_PTR(u8, buffer));
+ return ACPI_CAST_PTR(u8, buffer);
}
/*******************************************************************************
--
2.34.1
next reply other threads:[~2025-08-03 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-03 11:38 dikshakdevgan [this message]
2025-08-03 14:36 ` Markus Elfring
2025-08-03 15:18 ` Diksha Kumari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250803113820.16578-1-dikshakdevgan@gmail.com \
--to=dikshakdevgan@gmail.com \
--cc=acpica-devel@lists.linux.dev \
--cc=dkdevgan@outlook.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®