From: Markus Elfring <Markus.Elfring@web.de>
To: Diksha Kumari <dkdevgan@outlook.com>,
linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev
Cc: dikshakdevgan@gmail.com, LKML <linux-kernel@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Robert Moore <robert.moore@intel.com>
Subject: Re: [PATCH] acpi: remove unnecessary paranthesis from return
Date: Sun, 3 Aug 2025 16:36:30 +0200 [thread overview]
Message-ID: <50cafc07-563e-41a7-9286-54db8a7ac731@web.de> (raw)
In-Reply-To: <20250803113820.16578-1-dikshakdevgan@gmail.com>
> checkpatch.pl is generating a warning when return value is
> enclosed in paranthesis. Remove the paranthesis to improve
…
parenthesis?
You may occasionally put more than 58 characters into text lines
of such a change description.
Please avoid a typo also in the summary phrase.
…
> +++ b/drivers/acpi/acpica/dbconvert.c
> @@ -32,7 +32,7 @@ acpi_status acpi_db_hex_char_to_value(int hex_char, u8 *return_value)
> /* Digit must be ascii [0-9a-fA-F] */
>
> if (!isxdigit(hex_char)) {
> - return (AE_BAD_HEX_CONSTANT);
> + return AE_BAD_HEX_CONSTANT;
> }
…
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n197
Regards,
Markus
next prev parent reply other threads:[~2025-08-03 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-03 11:38 dikshakdevgan
2025-08-03 14:36 ` Markus Elfring [this message]
2025-08-03 15:18 ` Diksha Kumari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50cafc07-563e-41a7-9286-54db8a7ac731@web.de \
--to=markus.elfring@web.de \
--cc=acpica-devel@lists.linux.dev \
--cc=dikshakdevgan@gmail.com \
--cc=dkdevgan@outlook.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®