mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: lee@kernel.org
Cc: heiko@sntech.de, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] mfd: qnap-mcu: Some fixes / improvements
Date: Mon,  4 Aug 2025 15:07:22 +0200	[thread overview]
Message-ID: <20250804130726.3180806-1-heiko@sntech.de> (raw)

While digging through the mcu functions, I came across some deficits I
introduced with the initial driver submission, so trying to make that
a bit nicer with this series.


I struggled a bit with the ordering of qnap_mcu_write error-check
and conversion to guard(mutex). Converting to guard before the
error check would need dropping the ret variable, just to re-add it
one patch later - to not cause unused variable warning.

Additionally the error handling could be considered a fix, so makes
sense to have in front.


Heiko Stuebner (4):
  mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header
  mfd: qnap-mcu: handle errors returned from qnap_mcu_write
  mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec
  mfd: qnap-mcu: improve structure in qnap_mcu_exec

 drivers/mfd/qnap-mcu.c       | 30 +++++++++++++++---------------
 include/linux/mfd/qnap-mcu.h |  2 ++
 2 files changed, 17 insertions(+), 15 deletions(-)

-- 
2.47.2


             reply	other threads:[~2025-08-04 13:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 13:07 Heiko Stuebner [this message]
2025-08-04 13:07 ` [PATCH 1/4] mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header Heiko Stuebner
2025-08-04 13:07 ` [PATCH 2/4] mfd: qnap-mcu: handle errors returned from qnap_mcu_write Heiko Stuebner
2025-08-04 13:07 ` [PATCH 3/4] mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec Heiko Stuebner
2025-08-04 13:07 ` [PATCH 4/4] mfd: qnap-mcu: improve structure " Heiko Stuebner
2025-09-02  7:58 ` [PATCH 0/4] mfd: qnap-mcu: Some fixes / improvements Lee Jones
2025-09-02  8:00   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250804130726.3180806-1-heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®