From: Heiko Stuebner <heiko@sntech.de>
To: lee@kernel.org
Cc: heiko@sntech.de, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header
Date: Mon, 4 Aug 2025 15:07:23 +0200 [thread overview]
Message-ID: <20250804130726.3180806-2-heiko@sntech.de> (raw)
In-Reply-To: <20250804130726.3180806-1-heiko@sntech.de>
Relying on other components to include those basic types is unrelyable
and may cause compile errors like:
../include/linux/mfd/qnap-mcu.h:13:9: error: unknown type name ‘u32’
13 | u32 baud_rate;
| ^~~
../include/linux/mfd/qnap-mcu.h:17:9: error: unknown type name ‘bool’
17 | bool usb_led;
| ^~~~
So make sure, the types used in the header are available.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
include/linux/mfd/qnap-mcu.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/qnap-mcu.h b/include/linux/mfd/qnap-mcu.h
index 8d48c212fd44..42bf523f9a5b 100644
--- a/include/linux/mfd/qnap-mcu.h
+++ b/include/linux/mfd/qnap-mcu.h
@@ -7,6 +7,8 @@
#ifndef _LINUX_QNAP_MCU_H_
#define _LINUX_QNAP_MCU_H_
+#include <linux/types.h>
+
struct qnap_mcu;
struct qnap_mcu_variant {
--
2.47.2
next prev parent reply other threads:[~2025-08-04 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 13:07 [PATCH 0/4] mfd: qnap-mcu: Some fixes / improvements Heiko Stuebner
2025-08-04 13:07 ` Heiko Stuebner [this message]
2025-08-04 13:07 ` [PATCH 2/4] mfd: qnap-mcu: handle errors returned from qnap_mcu_write Heiko Stuebner
2025-08-04 13:07 ` [PATCH 3/4] mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec Heiko Stuebner
2025-08-04 13:07 ` [PATCH 4/4] mfd: qnap-mcu: improve structure " Heiko Stuebner
2025-09-02 7:58 ` [PATCH 0/4] mfd: qnap-mcu: Some fixes / improvements Lee Jones
2025-09-02 8:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804130726.3180806-2-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®