From: Rob Clark <robin.clark@oss.qualcomm.com>
To: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Danilo Krummrich <dakr@redhat.com>,
Connor Abbott <cwabbott0@gmail.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Lyude Paul <lyude@redhat.com>, Danilo Krummrich <dakr@kernel.org>,
linux-kernel@vger.kernel.org (open list),
nouveau@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA
GEFORCE/QUADRO GPUS)
Subject: [PATCH RESEND 1/2] drm/gpuvm: Send in-place re-maps to the driver as remap
Date: Mon, 4 Aug 2025 14:43:15 -0700 [thread overview]
Message-ID: <20250804214317.658704-2-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20250804214317.658704-1-robin.clark@oss.qualcomm.com>
The 'keep' hint on the unmap is only half useful, without being able to
link it to a map cb. Instead combine the two ops into a remap op to
give the driver a chance to figure things out.
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
---
drivers/gpu/drm/drm_gpuvm.c | 21 +++++++++++++++++++++
drivers/gpu/drm/nouveau/nouveau_uvmm.c | 3 ++-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index bbc7fecb6f4a..e21782a97fbe 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -2125,6 +2125,27 @@ __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm,
offset == req_offset;
if (end == req_end) {
+ if (merge) {
+ /*
+ * This is an exact remap of the existing
+ * VA (potentially flags change)? Pass
+ * this to the driver as a remap so it can
+ * do an in-place update:
+ */
+ struct drm_gpuva_op_map n = {
+ .va.addr = va->va.addr,
+ .va.range = va->va.range,
+ .gem.obj = va->gem.obj,
+ .gem.offset = va->gem.offset,
+ };
+ struct drm_gpuva_op_unmap u = {
+ .va = va,
+ .keep = true,
+ };
+
+ return op_remap_cb(ops, priv, NULL, &n, &u);
+ }
+
ret = op_unmap_cb(ops, priv, va, merge);
if (ret)
return ret;
diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
index 48f105239f42..c3e3a15eb3c8 100644
--- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
@@ -820,7 +820,8 @@ op_remap(struct drm_gpuva_op_remap *r,
if (r->next)
end = r->next->va.addr;
- op_unmap_range(u, addr, end - addr);
+ if (!u->keep)
+ op_unmap_range(u, addr, end - addr);
}
static int
--
2.50.1
next prev parent reply other threads:[~2025-08-04 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 21:43 [PATCH RESEND 0/2] drm/gpuvm+msm: Handle in-place remaps Rob Clark
2025-08-04 21:43 ` Rob Clark [this message]
2025-08-05 9:33 ` [PATCH RESEND 1/2] drm/gpuvm: Send in-place re-maps to the driver as remap Danilo Krummrich
2025-08-05 14:32 ` Rob Clark
2025-08-05 14:48 ` Danilo Krummrich
2025-08-05 14:59 ` Rob Clark
2025-08-04 21:43 ` [PATCH RESEND 2/2] drm/msm: Handle in-place remaps Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804214317.658704-2-robin.clark@oss.qualcomm.com \
--to=robin.clark@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=cwabbott0@gmail.com \
--cc=dakr@kernel.org \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®