From: Rob Clark <robin.clark@oss.qualcomm.com>
To: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Danilo Krummrich <dakr@redhat.com>,
Connor Abbott <cwabbott0@gmail.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH RESEND 2/2] drm/msm: Handle in-place remaps
Date: Mon, 4 Aug 2025 14:43:16 -0700 [thread overview]
Message-ID: <20250804214317.658704-3-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20250804214317.658704-1-robin.clark@oss.qualcomm.com>
Handle the special case of a MAP op simply updating the va flags by
detecting the special case, and skip pgtable updates.
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
---
drivers/gpu/drm/msm/msm_gem_vma.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
index dc54c693b28d..d4b1cfb3aa03 100644
--- a/drivers/gpu/drm/msm/msm_gem_vma.c
+++ b/drivers/gpu/drm/msm/msm_gem_vma.c
@@ -519,9 +519,10 @@ msm_gem_vm_sm_step_map(struct drm_gpuva_op *op, void *arg)
}
static int
-msm_gem_vm_sm_step_remap(struct drm_gpuva_op *op, void *arg)
+msm_gem_vm_sm_step_remap(struct drm_gpuva_op *op, void *_arg)
{
- struct msm_vm_bind_job *job = ((struct op_arg *)arg)->job;
+ struct op_arg *arg = _arg;
+ struct msm_vm_bind_job *job = arg->job;
struct drm_gpuvm *vm = job->vm;
struct drm_gpuva *orig_vma = op->remap.unmap->va;
struct drm_gpuva *prev_vma = NULL, *next_vma = NULL;
@@ -529,6 +530,18 @@ msm_gem_vm_sm_step_remap(struct drm_gpuva_op *op, void *arg)
bool mapped = to_msm_vma(orig_vma)->mapped;
unsigned flags;
+ /* Special case for in-place updates: */
+ if (op->remap.unmap->keep && arg->flags &&
+ op->remap.next && !op->remap.prev &&
+ (orig_vma->gem.obj == op->remap.next->gem.obj) &&
+ (orig_vma->gem.offset == op->remap.next->gem.offset) &&
+ (orig_vma->va.addr == op->remap.next->va.addr) &&
+ (orig_vma->va.range == op->remap.next->va.range)) {
+ /* Only flags are changing, so update that in-place: */
+ unsigned orig_flags = orig_vma->flags & (DRM_GPUVA_USERBITS - 1);
+ orig_vma->flags |= orig_flags | arg->flags;
+ }
+
vm_dbg("orig_vma: %p:%p:%p: %016llx %016llx", vm, orig_vma,
orig_vma->gem.obj, orig_vma->va.addr, orig_vma->va.range);
--
2.50.1
prev parent reply other threads:[~2025-08-04 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 21:43 [PATCH RESEND 0/2] drm/gpuvm+msm: " Rob Clark
2025-08-04 21:43 ` [PATCH RESEND 1/2] drm/gpuvm: Send in-place re-maps to the driver as remap Rob Clark
2025-08-05 9:33 ` Danilo Krummrich
2025-08-05 14:32 ` Rob Clark
2025-08-05 14:48 ` Danilo Krummrich
2025-08-05 14:59 ` Rob Clark
2025-08-04 21:43 ` Rob Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804214317.658704-3-robin.clark@oss.qualcomm.com \
--to=robin.clark@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=cwabbott0@gmail.com \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®