* [PATCH] uprobes: Remove redundant __GFP_NOWARN
@ 2025-08-05 2:50 Qianfeng Rong
2025-08-05 11:33 ` Oleg Nesterov
2025-08-25 10:24 ` [tip: perf/core] " tip-bot2 for Qianfeng Rong
0 siblings, 2 replies; 3+ messages in thread
From: Qianfeng Rong @ 2025-08-05 2:50 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Liang, Kan, Masami Hiramatsu,
Oleg Nesterov, linux-perf-users, linux-kernel,
linux-trace-kernel
Cc: willy, Qianfeng Rong
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
made GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
up these redundant flags across subsystems.
No functional changes.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
kernel/events/uprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 7ca1940607bd..5d12b9fdc917 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1210,7 +1210,7 @@ build_map_info(struct address_space *mapping, loff_t offset, bool is_register)
* reclaim. This is optimistic, no harm done if it fails.
*/
prev = kmalloc(sizeof(struct map_info),
- GFP_NOWAIT | __GFP_NOMEMALLOC | __GFP_NOWARN);
+ GFP_NOWAIT | __GFP_NOMEMALLOC);
if (prev)
prev->next = NULL;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uprobes: Remove redundant __GFP_NOWARN
2025-08-05 2:50 [PATCH] uprobes: Remove redundant __GFP_NOWARN Qianfeng Rong
@ 2025-08-05 11:33 ` Oleg Nesterov
2025-08-25 10:24 ` [tip: perf/core] " tip-bot2 for Qianfeng Rong
1 sibling, 0 replies; 3+ messages in thread
From: Oleg Nesterov @ 2025-08-05 11:33 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, Liang, Kan, Masami Hiramatsu,
linux-perf-users, linux-kernel, linux-trace-kernel, willy
On 08/05, Qianfeng Rong wrote:
>
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
> made GFP_NOWAIT implicitly include __GFP_NOWARN.
>
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
> (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
> up these redundant flags across subsystems.
>
> No functional changes.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: perf/core] uprobes: Remove redundant __GFP_NOWARN
2025-08-05 2:50 [PATCH] uprobes: Remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-05 11:33 ` Oleg Nesterov
@ 2025-08-25 10:24 ` tip-bot2 for Qianfeng Rong
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Qianfeng Rong @ 2025-08-25 10:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: Qianfeng Rong, Peter Zijlstra (Intel), Oleg Nesterov, x86, linux-kernel
The following commit has been merged into the perf/core branch of tip:
Commit-ID: e173287b5d2119971fc329473a020171836d14c9
Gitweb: https://git.kernel.org/tip/e173287b5d2119971fc329473a020171836d14c9
Author: Qianfeng Rong <rongqianfeng@vivo.com>
AuthorDate: Tue, 05 Aug 2025 10:50:00 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 21 Aug 2025 20:09:26 +02:00
uprobes: Remove redundant __GFP_NOWARN
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
made GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
up these redundant flags across subsystems.
No functional changes.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20250805025000.346647-1-rongqianfeng@vivo.com
---
kernel/events/uprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 4a194d7..996a810 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1220,7 +1220,7 @@ build_map_info(struct address_space *mapping, loff_t offset, bool is_register)
* reclaim. This is optimistic, no harm done if it fails.
*/
prev = kmalloc(sizeof(struct map_info),
- GFP_NOWAIT | __GFP_NOMEMALLOC | __GFP_NOWARN);
+ GFP_NOWAIT | __GFP_NOMEMALLOC);
if (prev)
prev->next = NULL;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-25 10:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-05 2:50 [PATCH] uprobes: Remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-05 11:33 ` Oleg Nesterov
2025-08-25 10:24 ` [tip: perf/core] " tip-bot2 for Qianfeng Rong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®