mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jai Luthra <jai.luthra@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	 Sakari Ailus <sakari.ailus@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Hans Verkuil <hverkuil@kernel.org>
Cc: Devarsh Thakkar <devarsht@ti.com>,
	 Rishikesh Donadkar <r-donadkar@ti.com>,
	 Yemike Abhilash Chandra <y-abhilashchandra@ti.com>,
	 linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Jai Luthra <jai.luthra@ideasonboard.com>,
	stable@vger.kernel.org
Subject: [PATCH v4 1/6] media: ti: j721e-csi2rx: Use devm_of_platform_populate
Date: Mon, 11 Aug 2025 13:50:13 +0530	[thread overview]
Message-ID: <20250811-probe_fixes-v4-1-aae22290f1d0@ideasonboard.com> (raw)
In-Reply-To: <20250811-probe_fixes-v4-0-aae22290f1d0@ideasonboard.com>

Ensure that we clean up the platform bus when we remove this driver.

This fixes a crash seen when reloading the module for the child device
with the parent not yet reloaded.

Fixes: b4a3d877dc92 ("media: ti: Add CSI2RX support for J721E")
Cc: stable@vger.kernel.org
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Tested-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> (on SK-AM68)
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
index b628d6e081dbcb4dae06a236455228c168945660..6d4cccbe1fdea11f6aefd63a985a9a3c16a7a9fe 100644
--- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
+++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
@@ -1120,7 +1120,7 @@ static int ti_csi2rx_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_vb2q;
 
-	ret = of_platform_populate(csi->dev->of_node, NULL, NULL, csi->dev);
+	ret = devm_of_platform_populate(csi->dev);
 	if (ret) {
 		dev_err(csi->dev, "Failed to create children: %d\n", ret);
 		goto err_subdev;

-- 
2.50.1


  reply	other threads:[~2025-08-11  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11  8:20 [PATCH v4 0/6] media: ti, cdns: Multiple pixel support and misc fixes Jai Luthra
2025-08-11  8:20 ` Jai Luthra [this message]
2025-08-11  8:20 ` [PATCH v4 2/6] media: ti: j721e-csi2rx: Use fwnode_get_named_child_node Jai Luthra
2025-08-11  8:20 ` [PATCH v4 3/6] media: ti: j721e-csi2rx: Fix source subdev link creation Jai Luthra
2025-08-11  8:20 ` [PATCH v4 4/6] media: cadence: csi2rx: Implement get_fwnode_pad op Jai Luthra
2025-08-11  8:20 ` [PATCH v4 5/6] media: cadence: cdns-csi2rx: Support multiple pixels per clock cycle Jai Luthra
2025-08-11  8:20 ` [PATCH v4 6/6] media: ti: j721e-csi2rx: Support multiple pixels per clock Jai Luthra
2025-08-19  5:53 ` [PATCH v4 0/6] media: ti, cdns: Multiple pixel support and misc fixes Rishikesh Donadkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250811-probe_fixes-v4-1-aae22290f1d0@ideasonboard.com \
    --to=jai.luthra@ideasonboard.com \
    --cc=devarsht@ti.com \
    --cc=hverkuil@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=r-donadkar@ti.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=y-abhilashchandra@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®