Re: [PATCH v4 0/6] media: ti, cdns: Multiple pixel support and misc fixes

[Rishikesh Donadkar <r-donadkar@ti.com>]

On 11/08/25 13:50, Jai Luthra wrote:
> Hi,


Hi Jai,
Thank you for the patches !


>
> The first four patches in this series are miscellaneous fixes and
> improvements in the Cadence and TI CSI-RX drivers around probing, fwnode
> and link creation.
>
> The last two patches add support for transmitting multiple pixels per
> clock on the internal bus between Cadence CSI-RX bridge and TI CSI-RX
> wrapper. As this internal bus is 32-bit wide, the maximum number of
> pixels that can be transmitted per cycle depend upon the format's bit
> width. Secondly, the downstream element must support unpacking of
> multiple pixels.
>
> Thus we export a module function that can be used by the downstream
> driver to negotiate the pixels per cycle on the output pixel stream of
> the Cadence bridge.
>
> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>


For the entire series,

Reviewed-by: Rishikesh Donadkar <r-donadkar@ti.com>

Tested-by: Rishikesh Donadkar <r-donadkar@ti.com>


Test Logs (SK-AM62A + IMX219) :

https://gist.github.com/Rishikesh-D/cb1d06cf341c2327da0d38a6b21688d6


Regards,

Rishikesh

> ---
> Changes in v4:
> - Rebase on top of v6.17-rc1
> - Add missing include for linux/export.h in cdns-csi2rx.c
> - Link to v3: https://lore.kernel.org/r/20250626-probe_fixes-v3-0-83e735ae466e@ideasonboard.com
>
> Changes in v3:
> - Move cdns-csi2rx header to include/media
> - Export symbol from cdns-csi2rx.c to be used only through
>    the j721e-csi2rx.c module namespace
> - Other minor fixes suggested by Sakari
> - Add Abhilash's T-by tags
> - Link to v2: https://lore.kernel.org/r/20250410-probe_fixes-v2-0-801bc6eebdea@ideasonboard.com
>
> Changes in v2:
> - Rebase on v6.15-rc1
> - Fix lkp warnings in PATCH 5/6 missing header for FIELD_PREP
> - Add R-By tags from Devarsh and Changhuang
> - Link to v1: https://lore.kernel.org/r/20250324-probe_fixes-v1-0-5cd5b9e1cfac@ideasonboard.com
>
> ---
> Jai Luthra (6):
>        media: ti: j721e-csi2rx: Use devm_of_platform_populate
>        media: ti: j721e-csi2rx: Use fwnode_get_named_child_node
>        media: ti: j721e-csi2rx: Fix source subdev link creation
>        media: cadence: csi2rx: Implement get_fwnode_pad op
>        media: cadence: cdns-csi2rx: Support multiple pixels per clock cycle
>        media: ti: j721e-csi2rx: Support multiple pixels per clock
>
>   MAINTAINERS                                        |  1 +
>   drivers/media/platform/cadence/cdns-csi2rx.c       | 75 ++++++++++++++++------
>   drivers/media/platform/ti/Kconfig                  |  3 +-
>   .../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c  | 65 ++++++++++++++-----
>   include/media/cadence/cdns-csi2rx.h                | 19 ++++++
>   5 files changed, 128 insertions(+), 35 deletions(-)
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250314-probe_fixes-7e0ec33c7fee
>
> Best regards,