From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Cc: linux-kernel@vger.kernel.org, "Thomas Weißschuh" <linux@weissschuh.net>
Subject: [PATCH v3 2/7] sysfs: transparently handle const pointers in ATTRIBUTE_GROUPS()
Date: Mon, 11 Aug 2025 11:14:28 +0200 [thread overview]
Message-ID: <20250811-sysfs-const-attr-prep-v3-2-0d973ff46afc@weissschuh.net> (raw)
In-Reply-To: <20250811-sysfs-const-attr-prep-v3-0-0d973ff46afc@weissschuh.net>
To ease the constification process of 'struct attribute', transparently
handle the const pointers in ATTRIBUTE_GROUPS().
A cast is used instead of assigning to .attrs_new as it keeps the macro
smaller. As both members are aliased to each other the result is
identical.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
include/linux/sysfs.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index a47092e837d9eb014894d1f7e49f0fd0f9a2e350..118a9b1d3b3e7528fb213d83f85d31bbac0dc309 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -290,7 +290,12 @@ static const struct attribute_group *_name##_groups[] = { \
#define ATTRIBUTE_GROUPS(_name) \
static const struct attribute_group _name##_group = { \
- .attrs = _name##_attrs, \
+ .attrs = _Generic(_name##_attrs, \
+ struct attribute **: \
+ _name##_attrs, \
+ const struct attribute *const *: \
+ (void *)_name##_attrs \
+ ), \
}; \
__ATTRIBUTE_GROUPS(_name)
--
2.50.1
next prev parent reply other threads:[~2025-08-11 9:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 9:14 [PATCH v3 0/7] sysfs: prepare the constification of struct attribute Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 1/7] sysfs: attribute_group: allow registration of const attribute Thomas Weißschuh
2025-08-19 11:22 ` Greg Kroah-Hartman
2025-08-19 13:59 ` Thomas Weißschuh
2025-08-19 14:10 ` Greg Kroah-Hartman
2025-08-19 14:15 ` Thomas Weißschuh
2025-08-11 9:14 ` Thomas Weißschuh [this message]
2025-08-11 9:14 ` [PATCH v3 3/7] sysfs: introduce __SYSFS_FUNCTION_ALTERNATIVE() Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 4/7] sysfs: attribute_group: enable const variants of is_visible() Thomas Weißschuh
2025-08-19 11:28 ` Greg Kroah-Hartman
2025-08-19 14:07 ` Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 5/7] samples/kobject: add is_visible() callback to attribute group Thomas Weißschuh
2025-08-19 11:24 ` Greg Kroah-Hartman
2025-08-19 14:00 ` Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 6/7] samples/kobject: constify 'struct foo_attribute' Thomas Weißschuh
2025-08-19 11:27 ` Greg Kroah-Hartman
2025-08-11 9:14 ` [PATCH v3 7/7] sysfs: simplify attribute definition macros Thomas Weißschuh
2025-08-12 14:36 ` [PATCH v3 0/7] sysfs: prepare the constification of struct attribute Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811-sysfs-const-attr-prep-v3-2-0d973ff46afc@weissschuh.net \
--to=linux@weissschuh.net \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®