From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/7] sysfs: attribute_group: allow registration of const attribute
Date: Tue, 19 Aug 2025 16:10:42 +0200 [thread overview]
Message-ID: <2025081953-canteen-criteria-c604@gregkh> (raw)
In-Reply-To: <daafd875-d3bc-4df7-a035-5a7dccdaaafb@t-8ch.de>
On Tue, Aug 19, 2025 at 03:59:04PM +0200, Thomas Weißschuh wrote:
> On 2025-08-19 13:22:55+0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 11, 2025 at 11:14:27AM +0200, Thomas Weißschuh wrote:
> > > To be able to constify instances of struct attribute it has to be
> > > possible to add them to struct attribute_group.
> > > The current type of the attrs member however is not compatible with that.
> > > Introduce a union that allows registration of both const and non-const
> > > attributes to enable a piecewise transition.
> > > As both union member types are compatible no logic needs to be adapted.
> > >
> > > Technically it is now possible register a const struct
> > > attribute and receive it as mutable pointer in the callbacks.
> > > This is a soundness issue.
> > > But this same soundness issue already exists today in
> > > sysfs_create_file().
> > > Also the struct definition and callback implementation are always
> > > closely linked and are meant to be moved to const in lockstep.
> > >
> > > Similar to commit 906c508afdca ("sysfs: attribute_group: allow registration of const bin_attribute")
> > >
> > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > > ---
> > > include/linux/sysfs.h | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> > > index f418aae4f1134f8126783d9e8eb575ba4278e927..a47092e837d9eb014894d1f7e49f0fd0f9a2e350 100644
> > > --- a/include/linux/sysfs.h
> > > +++ b/include/linux/sysfs.h
> > > @@ -105,7 +105,10 @@ struct attribute_group {
> > > size_t (*bin_size)(struct kobject *,
> > > const struct bin_attribute *,
> > > int);
> > > - struct attribute **attrs;
> > > + union {
> > > + struct attribute **attrs;
> > > + const struct attribute *const *attrs_new;
> >
> > I know you will drop the "_new" prefix after a while, but "new" is
> > relative, and not very descriptive.
>
> That is somewhat intentional to express that it is a transitional thing.
Fair, but given the huge quantity here, it's going to take a long time,
so "new" is going to be rough to push through for 6+ months.
> > How about "_const"?
>
> At some point the regular variant will be const too, so "_const" would
> be a bit weird.
Yes, that's when you "switch it back", right? You would have to do that
for _new as well.
thanks,
greg k-h
next prev parent reply other threads:[~2025-08-19 14:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 9:14 [PATCH v3 0/7] sysfs: prepare the constification of struct attribute Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 1/7] sysfs: attribute_group: allow registration of const attribute Thomas Weißschuh
2025-08-19 11:22 ` Greg Kroah-Hartman
2025-08-19 13:59 ` Thomas Weißschuh
2025-08-19 14:10 ` Greg Kroah-Hartman [this message]
2025-08-19 14:15 ` Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 2/7] sysfs: transparently handle const pointers in ATTRIBUTE_GROUPS() Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 3/7] sysfs: introduce __SYSFS_FUNCTION_ALTERNATIVE() Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 4/7] sysfs: attribute_group: enable const variants of is_visible() Thomas Weißschuh
2025-08-19 11:28 ` Greg Kroah-Hartman
2025-08-19 14:07 ` Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 5/7] samples/kobject: add is_visible() callback to attribute group Thomas Weißschuh
2025-08-19 11:24 ` Greg Kroah-Hartman
2025-08-19 14:00 ` Thomas Weißschuh
2025-08-11 9:14 ` [PATCH v3 6/7] samples/kobject: constify 'struct foo_attribute' Thomas Weißschuh
2025-08-19 11:27 ` Greg Kroah-Hartman
2025-08-11 9:14 ` [PATCH v3 7/7] sysfs: simplify attribute definition macros Thomas Weißschuh
2025-08-12 14:36 ` [PATCH v3 0/7] sysfs: prepare the constification of struct attribute Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081953-canteen-criteria-c604@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®