From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Kees Cook <kees@kernel.org>
Subject: Re: [patch V2 m@/6] perf/core: Split out mlock limit handling
Date: Mon, 11 Aug 2025 16:40:47 +0200 [thread overview]
Message-ID: <20250811144047.GA4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <87o6sm81wt.ffs@tglx>
On Mon, Aug 11, 2025 at 02:42:58PM +0200, Thomas Gleixner wrote:
> > Does this not also need this? I found this stray user_extra when I
> > eventually removed the local user_extra variable.
> >
> >
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -6997,8 +6997,6 @@ static int perf_mmap(struct file *file,
> > if (vma_size != PAGE_SIZE * nr_pages)
> > return -EINVAL;
> >
> > - user_extra = nr_pages;
> > -
> > mutex_lock(&event->mmap_mutex);
> > ret = -EINVAL;
> >
>
> No. That's how user_extra is initialized in the first place.
>
> To remove that nr_pages must become an argument to that function.
Ah, I see. Let me go fix that.
next prev parent reply other threads:[~2025-08-11 14:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 7:06 [patch V2 m@/6] perf: Convert mmap() related reference counts to refcount_t Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Remove redundant condition for AUX buffer size Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split out mlock limit handling Thomas Gleixner
2025-08-11 10:49 ` Peter Zijlstra
2025-08-11 12:42 ` Thomas Gleixner
2025-08-11 14:40 ` Peter Zijlstra [this message]
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split out VM accounting Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split out AUX buffer allocation Thomas Gleixner
2025-08-11 9:04 ` Peter Zijlstra
2025-08-11 9:36 ` Peter Zijlstra
2025-08-11 10:04 ` Peter Zijlstra
2025-08-11 12:28 ` Peter Zijlstra
2025-08-11 12:46 ` Thomas Gleixner
2025-08-11 12:44 ` Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split the ringbuffer mmap() and allocation code out Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Convert mmap() refcounts to refcount_t Thomas Gleixner
2025-08-11 8:02 ` [patch V2 m@/6] perf: Convert mmap() related reference counts " Lorenzo Stoakes
2025-08-11 12:32 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811144047.GA4067720@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®