From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Kees Cook <kees@kernel.org>
Subject: Re: [patch V2 m@/6] perf/core: Split out AUX buffer allocation
Date: Mon, 11 Aug 2025 14:44:19 +0200 [thread overview]
Message-ID: <87jz3a81uk.ffs@tglx> (raw)
In-Reply-To: <20250811100403.GE1613200@noisy.programming.kicks-ass.net>
On Mon, Aug 11 2025 at 12:04, Peter Zijlstra wrote:
> On Mon, Aug 11, 2025 at 09:06:41AM +0200, Thomas Gleixner wrote:
>> + /* If mapped, attach to it */
>> + if (rb_has_aux(rb)) {
>> + atomic_inc(&rb->aux_mmap_count);
>> + return 0;
>
> so this was: ret = 0; goto unlock;, which then would've also taken the
> !ret branch and done perf_mmap_account(), no?
Indeed.
> These two aux and rb split out patches seem like they're trying to take
> too big a step. Let me try and do the same with smaller steps.
>
> If only to try and find bugs.
:)
next prev parent reply other threads:[~2025-08-11 12:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 7:06 [patch V2 m@/6] perf: Convert mmap() related reference counts to refcount_t Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Remove redundant condition for AUX buffer size Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split out mlock limit handling Thomas Gleixner
2025-08-11 10:49 ` Peter Zijlstra
2025-08-11 12:42 ` Thomas Gleixner
2025-08-11 14:40 ` Peter Zijlstra
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split out VM accounting Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split out AUX buffer allocation Thomas Gleixner
2025-08-11 9:04 ` Peter Zijlstra
2025-08-11 9:36 ` Peter Zijlstra
2025-08-11 10:04 ` Peter Zijlstra
2025-08-11 12:28 ` Peter Zijlstra
2025-08-11 12:46 ` Thomas Gleixner
2025-08-11 12:44 ` Thomas Gleixner [this message]
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Split the ringbuffer mmap() and allocation code out Thomas Gleixner
2025-08-11 7:06 ` [patch V2 m@/6] perf/core: Convert mmap() refcounts to refcount_t Thomas Gleixner
2025-08-11 8:02 ` [patch V2 m@/6] perf: Convert mmap() related reference counts " Lorenzo Stoakes
2025-08-11 12:32 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz3a81uk.ffs@tglx \
--to=tglx@linutronix.de \
--cc=acme@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®