* [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
@ 2025-08-12 9:39 Pengyu Luo
2025-08-12 9:44 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pengyu Luo @ 2025-08-12 9:39 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Dmitry Baryshkov,
Neil Armstrong, Konrad Dybcio, Abel Vesa
Cc: Pengyu Luo, Luca Weiss, linux-arm-msm, linux-phy, linux-kernel
property "qcom,tune-usb2-preem" is for EUSB2_TUNE_USB2_PREEM
property "qcom,tune-usb2-amplitude" is for EUSB2_TUNE_IUSB2
The downstream correspondence is as follows:
EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuning
EUSB2_TUNE_IUSB2: HS trasmit amplitude
EUSB2_TUNE_SQUELCH_U: Squelch detection threshold
EUSB2_TUNE_HSDISC: HS disconnect threshold
EUSB2_TUNE_EUSB_SLEW: slew rate
Fixes: 31bc94de7602 ("phy: qualcomm: phy-qcom-eusb2-repeater: Don't zero-out registers")
Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
---
drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
index d7493c229..3709fba42 100644
--- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
+++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
@@ -127,13 +127,13 @@ static int eusb2_repeater_init(struct phy *phy)
rptr->cfg->init_tbl[i].value);
/* Override registers from devicetree values */
- if (!of_property_read_u8(np, "qcom,tune-usb2-amplitude", &val))
+ if (!of_property_read_u8(np, "qcom,tune-usb2-preem", &val))
regmap_write(regmap, base + EUSB2_TUNE_USB2_PREEM, val);
if (!of_property_read_u8(np, "qcom,tune-usb2-disc-thres", &val))
regmap_write(regmap, base + EUSB2_TUNE_HSDISC, val);
- if (!of_property_read_u8(np, "qcom,tune-usb2-preem", &val))
+ if (!of_property_read_u8(np, "qcom,tune-usb2-amplitude", &val))
regmap_write(regmap, base + EUSB2_TUNE_IUSB2, val);
/* Wait for status OK */
--
2.50.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
2025-08-12 9:39 [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties Pengyu Luo
@ 2025-08-12 9:44 ` Konrad Dybcio
2025-08-12 10:13 ` Luca Weiss
2025-08-12 16:40 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-08-12 9:44 UTC (permalink / raw)
To: Pengyu Luo, Vinod Koul, Kishon Vijay Abraham I, Dmitry Baryshkov,
Neil Armstrong, Abel Vesa
Cc: Luca Weiss, linux-arm-msm, linux-phy, linux-kernel
On 8/12/25 11:39 AM, Pengyu Luo wrote:
> property "qcom,tune-usb2-preem" is for EUSB2_TUNE_USB2_PREEM
> property "qcom,tune-usb2-amplitude" is for EUSB2_TUNE_IUSB2
>
> The downstream correspondence is as follows:
> EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuning
> EUSB2_TUNE_IUSB2: HS trasmit amplitude
> EUSB2_TUNE_SQUELCH_U: Squelch detection threshold
> EUSB2_TUNE_HSDISC: HS disconnect threshold
> EUSB2_TUNE_EUSB_SLEW: slew rate
The commit message is a bit.. dry.. but I suppose it conveys what
the problem is
>
> Fixes: 31bc94de7602 ("phy: qualcomm: phy-qcom-eusb2-repeater: Don't zero-out registers")
> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
2025-08-12 9:39 [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties Pengyu Luo
2025-08-12 9:44 ` Konrad Dybcio
@ 2025-08-12 10:13 ` Luca Weiss
2025-08-12 16:40 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Luca Weiss @ 2025-08-12 10:13 UTC (permalink / raw)
To: Pengyu Luo, Vinod Koul, Kishon Vijay Abraham I, Dmitry Baryshkov,
Neil Armstrong, Konrad Dybcio, Abel Vesa
Cc: linux-arm-msm, linux-phy, linux-kernel
On Tue Aug 12, 2025 at 11:39 AM CEST, Pengyu Luo wrote:
> property "qcom,tune-usb2-preem" is for EUSB2_TUNE_USB2_PREEM
> property "qcom,tune-usb2-amplitude" is for EUSB2_TUNE_IUSB2
>
> The downstream correspondence is as follows:
> EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuning
> EUSB2_TUNE_IUSB2: HS trasmit amplitude
> EUSB2_TUNE_SQUELCH_U: Squelch detection threshold
> EUSB2_TUNE_HSDISC: HS disconnect threshold
> EUSB2_TUNE_EUSB_SLEW: slew rate
>
> Fixes: 31bc94de7602 ("phy: qualcomm: phy-qcom-eusb2-repeater: Don't zero-out registers")
Oh, not sure how this happened. Thanks for catching this, I do see the
problem in my original commit.
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
Regards
Luca
> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
> ---
> drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> index d7493c229..3709fba42 100644
> --- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> +++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
> @@ -127,13 +127,13 @@ static int eusb2_repeater_init(struct phy *phy)
> rptr->cfg->init_tbl[i].value);
>
> /* Override registers from devicetree values */
> - if (!of_property_read_u8(np, "qcom,tune-usb2-amplitude", &val))
> + if (!of_property_read_u8(np, "qcom,tune-usb2-preem", &val))
> regmap_write(regmap, base + EUSB2_TUNE_USB2_PREEM, val);
>
> if (!of_property_read_u8(np, "qcom,tune-usb2-disc-thres", &val))
> regmap_write(regmap, base + EUSB2_TUNE_HSDISC, val);
>
> - if (!of_property_read_u8(np, "qcom,tune-usb2-preem", &val))
> + if (!of_property_read_u8(np, "qcom,tune-usb2-amplitude", &val))
> regmap_write(regmap, base + EUSB2_TUNE_IUSB2, val);
>
> /* Wait for status OK */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
2025-08-12 9:39 [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties Pengyu Luo
2025-08-12 9:44 ` Konrad Dybcio
2025-08-12 10:13 ` Luca Weiss
@ 2025-08-12 16:40 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2025-08-12 16:40 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Dmitry Baryshkov, Neil Armstrong,
Konrad Dybcio, Abel Vesa, Pengyu Luo
Cc: Luca Weiss, linux-arm-msm, linux-phy, linux-kernel
On Tue, 12 Aug 2025 17:39:56 +0800, Pengyu Luo wrote:
> property "qcom,tune-usb2-preem" is for EUSB2_TUNE_USB2_PREEM
> property "qcom,tune-usb2-amplitude" is for EUSB2_TUNE_IUSB2
>
> The downstream correspondence is as follows:
> EUSB2_TUNE_USB2_PREEM: Tx pre-emphasis tuning
> EUSB2_TUNE_IUSB2: HS trasmit amplitude
> EUSB2_TUNE_SQUELCH_U: Squelch detection threshold
> EUSB2_TUNE_HSDISC: HS disconnect threshold
> EUSB2_TUNE_EUSB_SLEW: slew rate
>
> [...]
Applied, thanks!
[1/1] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties
commit: 942e47ab228c7dd27c2ae043c17e7aab2028082c
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-12 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-12 9:39 [PATCH] phy: qualcomm: phy-qcom-eusb2-repeater: fix override properties Pengyu Luo
2025-08-12 9:44 ` Konrad Dybcio
2025-08-12 10:13 ` Luca Weiss
2025-08-12 16:40 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®