mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Sohil Mehta <sohil.mehta@intel.com>
Cc: Borislav Petkov <bp@kernel.org>, X86 ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/microcode: Add microcode= cmdline parsing
Date: Tue, 12 Aug 2025 12:23:45 +0200	[thread overview]
Message-ID: <20250812102345.GAaJsWMTNvC2ULKtep@fat_crate.local> (raw)
In-Reply-To: <f641cc0f-e542-45ef-bdb9-d8364860688e@intel.com>

On Mon, Aug 11, 2025 at 07:26:59PM -0700, Sohil Mehta wrote:
> How about adding something like this to encourage using the new options:
> 
> 
> @@ -1211,7 +1211,7 @@
> 
> -       dis_ucode_ldr   [X86] Disable the microcode loader.
> +       dis_ucode_ldr   [X86] Same as microcode=disable_loader.
> 
> 
> @@ -3770,6 +3770,9 @@
> 
> +                       disable_loader
> +                               Disable the microcode loader.

Because adding a new alias of a cmdline parameter doesn't belong in the same
patch.

And if anything, that thing should be

	microcode=off

to save me some silly typing.

> Unnecessary whitespace added before tab.

Pff.

> Setting this to "false" is redundant.

Fixed.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2025-08-12 10:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-09  9:42 [PATCH 0/2] x86/microcode: Add debugging glue Borislav Petkov
2025-08-09  9:42 ` [PATCH 1/2] x86/microcode: Add microcode= cmdline parsing Borislav Petkov
2025-08-12  2:26   ` Sohil Mehta
2025-08-12 10:23     ` Borislav Petkov [this message]
2025-08-12 19:14       ` Sohil Mehta
2025-08-12 21:28         ` Borislav Petkov
2025-08-14 23:08   ` Chang S. Bae
2025-08-15  9:20     ` Borislav Petkov
2025-08-15 19:50       ` Chang S. Bae
2025-08-18 16:30       ` Sohil Mehta
2025-08-09  9:42 ` [PATCH 2/2] x86/microcode: Add microcode loader debugging functionality Borislav Petkov
2025-08-12  3:04   ` Sohil Mehta
2025-08-12 10:26     ` Borislav Petkov
2025-08-12 18:57       ` Sohil Mehta
2025-08-12 19:09         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250812102345.GAaJsWMTNvC2ULKtep@fat_crate.local \
    --to=bp@alien8.de \
    --cc=bp@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sohil.mehta@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®