* [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c
@ 2025-08-12 15:37 Shubham Sharma
2025-08-13 22:05 ` Andrii Nakryiko
0 siblings, 1 reply; 3+ messages in thread
From: Shubham Sharma @ 2025-08-12 15:37 UTC (permalink / raw)
To: ast, daniel, andrii
Cc: martin.lau, eddyz87, song, yonghong.song, john.fastabend,
kpsingh, sdf, haoluo, jolsa, mykolal, shuah, bpf,
linux-kselftest, linux-kernel, Shubham Sharma
Fixed a spelling mistake:
- comparision -> comparison
Signed-off-by: Shubham Sharma <slopixelz@gmail.com>
---
tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
index e19ef509ebf8..f377bea0b82d 100644
--- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
+++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
@@ -463,7 +463,7 @@ static bool skip_entry(char *name)
return false;
}
-/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
+/* Do comparison by ignoring '.llvm.<hash>' suffixes. */
static int compare_name(const char *name1, const char *name2)
{
const char *res1, *res2;
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c
2025-08-12 15:37 [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c Shubham Sharma
@ 2025-08-13 22:05 ` Andrii Nakryiko
2025-08-14 12:29 ` Shubham Sharma
0 siblings, 1 reply; 3+ messages in thread
From: Andrii Nakryiko @ 2025-08-13 22:05 UTC (permalink / raw)
To: Shubham Sharma
Cc: ast, daniel, andrii, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, jolsa, mykolal, shuah, bpf,
linux-kselftest, linux-kernel
On Tue, Aug 12, 2025 at 8:37 AM Shubham Sharma <slopixelz@gmail.com> wrote:
>
> Fixed a spelling mistake:
> - comparision -> comparison
>
> Signed-off-by: Shubham Sharma <slopixelz@gmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> index e19ef509ebf8..f377bea0b82d 100644
> --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> @@ -463,7 +463,7 @@ static bool skip_entry(char *name)
> return false;
> }
>
> -/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
> +/* Do comparison by ignoring '.llvm.<hash>' suffixes. */
Is this the only typo in the entire BPF selftests? If we are doing
single character comment fixes, let's do it as one bigger pass,
instead of tons of tiny patches?
pw-bot: cr
> static int compare_name(const char *name1, const char *name2)
> {
> const char *res1, *res2;
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c
2025-08-13 22:05 ` Andrii Nakryiko
@ 2025-08-14 12:29 ` Shubham Sharma
0 siblings, 0 replies; 3+ messages in thread
From: Shubham Sharma @ 2025-08-14 12:29 UTC (permalink / raw)
To: Andrii Nakryiko
Cc: ast, daniel, andrii, martin.lau, eddyz87, song, yonghong.song,
john.fastabend, kpsingh, sdf, haoluo, jolsa, mykolal, shuah, bpf,
linux-kselftest, linux-kernel
On Thu, Aug 14, 2025 at 3:35 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Aug 12, 2025 at 8:37 AM Shubham Sharma <slopixelz@gmail.com> wrote:
> >
> > Fixed a spelling mistake:
> > - comparision -> comparison
> >
> > Signed-off-by: Shubham Sharma <slopixelz@gmail.com>
> > ---
> > tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > index e19ef509ebf8..f377bea0b82d 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_multi_test.c
> > @@ -463,7 +463,7 @@ static bool skip_entry(char *name)
> > return false;
> > }
> >
> > -/* Do comparision by ignoring '.llvm.<hash>' suffixes. */
> > +/* Do comparison by ignoring '.llvm.<hash>' suffixes. */
>
> Is this the only typo in the entire BPF selftests? If we are doing
> single character comment fixes, let's do it as one bigger pass,
> instead of tons of tiny patches?
>
> pw-bot: cr
>
>
> > static int compare_name(const char *name1, const char *name2)
> > {
> > const char *res1, *res2;
> > --
> > 2.43.0
> >
Thank you for the feedback. I understand that small, single-character
fixes are better grouped into a larger patch to avoid multiple tiny
commits.
I’ll review the BPF selftests code for similar typos and send a
combined patch instead.
Thanks,
Shubham Sharma
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-14 12:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-12 15:37 [PATCH] selftests/bpf: Fix typo in kprobe_multi_test.c Shubham Sharma
2025-08-13 22:05 ` Andrii Nakryiko
2025-08-14 12:29 ` Shubham Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®