From: Andrew Davis <afd@ti.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>
Subject: [PATCH 3/6] iio: health: afe4403: Use dev_err_probe() helper
Date: Wed, 13 Aug 2025 17:58:37 -0500 [thread overview]
Message-ID: <20250813225840.576305-3-afd@ti.com> (raw)
In-Reply-To: <20250813225840.576305-1-afd@ti.com>
This checks for EPROBE_DEFER and allows us to print out the error code
while return it directly saving some lines of code.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/iio/health/afe4403.c | 62 +++++++++++++-----------------------
1 file changed, 22 insertions(+), 40 deletions(-)
diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
index f9759f855c534..56953730c2bed 100644
--- a/drivers/iio/health/afe4403.c
+++ b/drivers/iio/health/afe4403.c
@@ -453,39 +453,31 @@ static int afe4403_probe(struct spi_device *spi)
afe->irq = spi->irq;
afe->regmap = devm_regmap_init_spi(spi, &afe4403_regmap_config);
- if (IS_ERR(afe->regmap)) {
- dev_err(dev, "Unable to allocate register map\n");
- return PTR_ERR(afe->regmap);
- }
+ if (IS_ERR(afe->regmap))
+ return dev_err_probe(dev, PTR_ERR(afe->regmap),
+ "Unable to allocate register map\n");
for (i = 0; i < F_MAX_FIELDS; i++) {
afe->fields[i] = devm_regmap_field_alloc(dev, afe->regmap,
afe4403_reg_fields[i]);
- if (IS_ERR(afe->fields[i])) {
- dev_err(dev, "Unable to allocate regmap fields\n");
- return PTR_ERR(afe->fields[i]);
- }
+ if (IS_ERR(afe->fields[i]))
+ return dev_err_probe(dev, PTR_ERR(afe->fields[i]),
+ "Unable to allocate regmap fields\n");
}
ret = devm_regulator_get_enable(dev, "tx_sup");
- if (ret) {
- dev_err(dev, "Unable to enable regulator\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Unable to enable regulator\n");
ret = regmap_write(afe->regmap, AFE440X_CONTROL0,
AFE440X_CONTROL0_SW_RESET);
- if (ret) {
- dev_err(dev, "Unable to reset device\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Unable to reset device\n");
ret = regmap_multi_reg_write(afe->regmap, afe4403_reg_sequences,
ARRAY_SIZE(afe4403_reg_sequences));
- if (ret) {
- dev_err(dev, "Unable to set register defaults\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Unable to set register defaults\n");
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->channels = afe4403_channels;
@@ -498,43 +490,33 @@ static int afe4403_probe(struct spi_device *spi)
"%s-dev%d",
indio_dev->name,
iio_device_id(indio_dev));
- if (!afe->trig) {
- dev_err(dev, "Unable to allocate IIO trigger\n");
- return -ENOMEM;
- }
+ if (!afe->trig)
+ return dev_err_probe(dev, -ENOMEM, "Unable to allocate IIO trigger\n");
iio_trigger_set_drvdata(afe->trig, indio_dev);
ret = devm_iio_trigger_register(dev, afe->trig);
- if (ret) {
- dev_err(dev, "Unable to register IIO trigger\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Unable to register IIO trigger\n");
ret = devm_request_threaded_irq(dev, afe->irq,
iio_trigger_generic_data_rdy_poll,
NULL, IRQF_ONESHOT,
AFE4403_DRIVER_NAME,
afe->trig);
- if (ret) {
- dev_err(dev, "Unable to request IRQ\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Unable to request IRQ\n");
}
ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
&iio_pollfunc_store_time,
afe4403_trigger_handler, NULL);
- if (ret) {
- dev_err(dev, "Unable to setup buffer\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Unable to setup buffer\n");
ret = devm_iio_device_register(dev, indio_dev);
- if (ret) {
- dev_err(dev, "Unable to register IIO device\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "Unable to register IIO device\n");
return 0;
}
--
2.39.2
next prev parent reply other threads:[~2025-08-13 22:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 22:58 [PATCH 1/6] iio: health: afe4403: Do not store dev pointer in device struct Andrew Davis
2025-08-13 22:58 ` [PATCH 2/6] iio: health: afe4403: Use devm_regulator_get_enable() helper Andrew Davis
2025-08-13 23:12 ` David Lechner
2025-09-13 14:20 ` Jonathan Cameron
2025-09-15 12:13 ` Andrew Davis
2025-08-13 22:58 ` Andrew Davis [this message]
2025-08-13 22:58 ` [PATCH 4/6] iio: health: afe4404: Do not store dev pointer in device struct Andrew Davis
2025-08-16 12:55 ` Jonathan Cameron
2025-08-13 22:58 ` [PATCH 5/6] iio: health: afe4404: Use devm_regulator_get_enable() helper Andrew Davis
2025-08-13 22:58 ` [PATCH 6/6] iio: health: afe4404: Use dev_err_probe() helper Andrew Davis
2025-08-16 12:53 ` [PATCH 1/6] iio: health: afe4403: Do not store dev pointer in device struct Jonathan Cameron
2025-08-20 14:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813225840.576305-3-afd@ti.com \
--to=afd@ti.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®