From: Andrew Davis <afd@ti.com>
To: Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] iio: health: afe4403: Use devm_regulator_get_enable() helper
Date: Mon, 15 Sep 2025 07:13:18 -0500 [thread overview]
Message-ID: <4333d98d-3f6c-4c22-8dee-e4349a7b4046@ti.com> (raw)
In-Reply-To: <20250913152052.134a4059@jic23-huawei>
On 9/13/25 9:20 AM, Jonathan Cameron wrote:
> On Wed, 13 Aug 2025 18:12:26 -0500
> David Lechner <dlechner@baylibre.com> wrote:
>
>> On 8/13/25 5:58 PM, Andrew Davis wrote:
>>> This takes care of both getting and enabling the regulator in one
>>> function, it also handles the devm action, so remove that. Also
>>> do not disable the regulator on suspend, this will be handled for
>>
>> I didn't know that this worked automatically. What is the mechanism
>> that makes it work? I've seen lots of drivers doing the disable/
>> enable in suspend/resume, so I just always assumed that was how one
>> is supposed to do it.
>>
> Hi Andrew
>
> This question is still open, so I'll not pick the reset of the series
> up until it's resolved. I'm going to mark these in patchwork as
> changes requested so will need a v2 now.
>
Sounds good, I'm still working on tracking down the answer to the
question. I think it involves the regulator suspend path but
will sort it out fully for v2.
Thanks,
Andrew
>
> Jonathan
>
>>> us. We now do not need to track the regulator at all, so drop it
>>> from the device struct.
>>>
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>
next prev parent reply other threads:[~2025-09-15 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 22:58 [PATCH 1/6] iio: health: afe4403: Do not store dev pointer in device struct Andrew Davis
2025-08-13 22:58 ` [PATCH 2/6] iio: health: afe4403: Use devm_regulator_get_enable() helper Andrew Davis
2025-08-13 23:12 ` David Lechner
2025-09-13 14:20 ` Jonathan Cameron
2025-09-15 12:13 ` Andrew Davis [this message]
2025-08-13 22:58 ` [PATCH 3/6] iio: health: afe4403: Use dev_err_probe() helper Andrew Davis
2025-08-13 22:58 ` [PATCH 4/6] iio: health: afe4404: Do not store dev pointer in device struct Andrew Davis
2025-08-16 12:55 ` Jonathan Cameron
2025-08-13 22:58 ` [PATCH 5/6] iio: health: afe4404: Use devm_regulator_get_enable() helper Andrew Davis
2025-08-13 22:58 ` [PATCH 6/6] iio: health: afe4404: Use dev_err_probe() helper Andrew Davis
2025-08-16 12:53 ` [PATCH 1/6] iio: health: afe4403: Do not store dev pointer in device struct Jonathan Cameron
2025-08-20 14:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4333d98d-3f6c-4c22-8dee-e4349a7b4046@ti.com \
--to=afd@ti.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®