From: Jakub Kicinski <kuba@kernel.org>
To: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 2/2] microchip: lan865x: fix missing configuration for Rev.B0/B1 as per AN1760
Date: Fri, 15 Aug 2025 18:40:19 -0700 [thread overview]
Message-ID: <20250815184019.68116359@kernel.org> (raw)
In-Reply-To: <20250813103355.70838-3-parthiban.veerasooran@microchip.com>
On Wed, 13 Aug 2025 16:03:55 +0530 Parthiban Veerasooran wrote:
> +#define LAN865X_REG_FIXUP 0x00010077
> +#define LAN865X_FIXUP_VALUE 0x0028
Looks like the application note explains what this register is and what
is the meaning of the bits in it. Please break this up and name
properly. "FIXUP_REGISTER" and "FIXUP_VALUE" is about as useful
as naming it "REGSITER_AT_10077" and "VALUE_28" :/
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-16 1:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 10:33 [PATCH net 0/2] Fixes on the Microchip's LAN865x driver Parthiban Veerasooran
2025-08-13 10:33 ` [PATCH net 1/2] microchip: lan865x: fix missing netif_start_queue() call on device open Parthiban Veerasooran
2025-08-13 10:33 ` [PATCH net 2/2] microchip: lan865x: fix missing configuration for Rev.B0/B1 as per AN1760 Parthiban Veerasooran
2025-08-16 1:40 ` Jakub Kicinski [this message]
2025-08-18 4:44 ` Parthiban.Veerasooran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815184019.68116359@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®