mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] binder: remove MODULE_LICENSE()
@ 2025-08-17 13:50 Carlos Llamas
  2025-08-18 20:37 ` Tiffany Yang
  0 siblings, 1 reply; 2+ messages in thread
From: Carlos Llamas @ 2025-08-17 13:50 UTC (permalink / raw)
  To: Alice Ryhl, Greg Kroah-Hartman, Arve Hjønnevåg,
	Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
	Carlos Llamas, Suren Baghdasaryan
  Cc: Tiffany Yang, John Stultz, kernel-team, linux-kernel,
	Salvatore Bonaccorso

The MODULE_LICENSE() macro is intended for drivers that can be built as
loadable modules. The binder driver is always built-in, using this macro
here is unnecessary and potentially confusing. Remove it.

Cc: Salvatore Bonaccorso <carnil@debian.org>
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
 drivers/android/binder.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 312b462e349d..28634f786e70 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -7088,5 +7088,3 @@ device_initcall(binder_init);
 
 #define CREATE_TRACE_POINTS
 #include "binder_trace.h"
-
-MODULE_LICENSE("GPL v2");
-- 
2.51.0.rc1.163.g2494970778-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] binder: remove MODULE_LICENSE()
  2025-08-17 13:50 [PATCH] binder: remove MODULE_LICENSE() Carlos Llamas
@ 2025-08-18 20:37 ` Tiffany Yang
  0 siblings, 0 replies; 2+ messages in thread
From: Tiffany Yang @ 2025-08-18 20:37 UTC (permalink / raw)
  To: Carlos Llamas
  Cc: Alice Ryhl, Greg Kroah-Hartman, Arve Hjønnevåg,
	Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
	Suren Baghdasaryan, John Stultz, kernel-team, linux-kernel,
	Salvatore Bonaccorso

Carlos Llamas <cmllamas@google.com> writes:

> The MODULE_LICENSE() macro is intended for drivers that can be built as
> loadable modules. The binder driver is always built-in, using this macro
> here is unnecessary and potentially confusing. Remove it.

> Cc: Salvatore Bonaccorso <carnil@debian.org>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
>   drivers/android/binder.c | 2 --
>   1 file changed, 2 deletions(-)

> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 312b462e349d..28634f786e70 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -7088,5 +7088,3 @@ device_initcall(binder_init);

>   #define CREATE_TRACE_POINTS
>   #include "binder_trace.h"
> -
> -MODULE_LICENSE("GPL v2");

Reviewed-by: Tiffany Yang <ynaffit@google.com>

-- 
Tiffany Y. Yang

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-18 20:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-17 13:50 [PATCH] binder: remove MODULE_LICENSE() Carlos Llamas
2025-08-18 20:37 ` Tiffany Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®