From: Jakub Kicinski <kuba@kernel.org>
To: Wen Gu <guwen@linux.alibaba.com>
Cc: richardcochran@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
xuanzhuo@linux.alibaba.com, dust.li@linux.alibaba.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH net-next v4] ptp: add Alibaba CIPU PTP clock driver
Date: Mon, 18 Aug 2025 09:05:19 -0700 [thread overview]
Message-ID: <20250818090519.33335d5e@kernel.org> (raw)
In-Reply-To: <2a98165b-a353-405d-83e0-ffbca1d41340@linux.alibaba.com>
On Sat, 16 Aug 2025 11:52:18 +0800 Wen Gu wrote:
> > This driver is lacking documentation. You need to describe how the user
> > is expected to interact with the device and document all these sysfs
> > attributes.
> >
>
> OK. I will add the description.
>
> Would you prefer me to create a related .rst file under Documentation/
> (perhaps in a new Documentation/clock/ptp/ directory?), or add the
> description comments directly in this driver source?
It's supposed to be user-facing documentation, so Documentation.
But you ignored David Woodhouse's response, and also skirted around
Andrew's comment on OS kernel being an abstraction layer. So if you
plan to post a v5 -- the documentation better clearly explain why
this is a PTP device, and not a real time clock.
next prev parent reply other threads:[~2025-08-18 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 11:53 Wen Gu
2025-08-15 18:38 ` Jakub Kicinski
2025-08-15 18:43 ` David Woodhouse
2025-08-19 3:00 ` Wen Gu
2025-08-16 3:52 ` Wen Gu
2025-08-16 15:37 ` Andrew Lunn
2025-08-17 3:01 ` Wen Gu
2025-08-17 15:56 ` Andrew Lunn
2025-08-18 3:04 ` Wen Gu
2025-08-18 16:05 ` Jakub Kicinski [this message]
2025-08-21 20:05 ` Richard Cochran
2025-08-21 20:12 ` David Woodhouse
2025-08-22 2:07 ` Wen Gu
2025-08-22 7:43 ` David Woodhouse
2025-08-30 8:41 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818090519.33335d5e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=dwmw2@infradead.org \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®