mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Wen Gu <guwen@linux.alibaba.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	richardcochran@gmail.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	xuanzhuo@linux.alibaba.com, dust.li@linux.alibaba.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH net-next v4] ptp: add Alibaba CIPU PTP clock driver
Date: Sun, 17 Aug 2025 17:56:49 +0200	[thread overview]
Message-ID: <616e3d48-b449-401c-8c8b-501fce66c59d@lunn.ch> (raw)
In-Reply-To: <6a467d85-b524-4962-a3f4-bb2dab157ed7@linux.alibaba.com>

On Sun, Aug 17, 2025 at 11:01:23AM +0800, Wen Gu wrote:
> 
> 
> On 2025/8/16 23:37, Andrew Lunn wrote:
> > > These sysfs are intended to provide diagnostics and informations.
> > 
> > Maybe they should be in debugfs if they are just diagnostics? You then
> > don't need to document them, because they are not ABI.
> > 
> > 	Andrew
> 
> Hi Andrew,
> 
> Thank you for the suggestion.
> 
> But these sysfs aren't only for developer debugging, some cloud components
> rely on the statistics to assess the health of PTP clocks or to perform
> corresponding actions based on the reg values. So I prefer to use the stable
> sysfs.

Doesn't this somewhat contradict what you said earlier:

   These sysfs are intended to provide diagnostics and informations.
   For users, interacting with this PTP clock works the same way as with other
   PTP clock, through the exposed chardev.

So users don't use just the standard chardev, they additionally need
sysfs.

Maybe take a step back. Do what Jakub suggested:

   Maybe it's just me, but in general I really wish someone stepped up
   and created a separate subsystem for all these cloud / vm clocks.
   They have nothing to do with PTP. In my mind PTP clocks are simple
   HW tickers on which we build all the time related stuff. While this
   driver reports the base year for the epoch and leap second status
   via sysfs.

Talk with the other cloud vendors and define a common set of
properties, rather than each vendor having their own incompatible set.

OS 101: the OS is supposed to abstract over the hardware to make
different hardware all look the same.

	Andrew

  reply	other threads:[~2025-08-17 15:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 11:53 Wen Gu
2025-08-15 18:38 ` Jakub Kicinski
2025-08-15 18:43   ` David Woodhouse
2025-08-19  3:00     ` Wen Gu
2025-08-16  3:52   ` Wen Gu
2025-08-16 15:37     ` Andrew Lunn
2025-08-17  3:01       ` Wen Gu
2025-08-17 15:56         ` Andrew Lunn [this message]
2025-08-18  3:04           ` Wen Gu
2025-08-18 16:05     ` Jakub Kicinski
2025-08-21 20:05   ` Richard Cochran
2025-08-21 20:12     ` David Woodhouse
2025-08-22  2:07       ` Wen Gu
2025-08-22  7:43         ` David Woodhouse
2025-08-30  8:41           ` Wen Gu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=616e3d48-b449-401c-8c8b-501fce66c59d@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dust.li@linux.alibaba.com \
    --cc=dwmw2@infradead.org \
    --cc=edumazet@google.com \
    --cc=guwen@linux.alibaba.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®