From: Salah Triki <salah.triki@gmail.com>
To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, Markus.Elfring@web.de, salah.triki@gmail.com
Subject: [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value_cansleep()
Date: Mon, 18 Aug 2025 10:27:32 +0100 [thread overview]
Message-ID: <20250818092740.545379-4-salah.triki@gmail.com> (raw)
In-Reply-To: <20250818092740.545379-1-salah.triki@gmail.com>
Switch to `gpiod_set_value_cansleep()`, which is safe to use in
sleepable contexts like the driver probe function.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/pressure/bmp280-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index 1f0852fc3414..656f6189c84c 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -3217,7 +3217,7 @@ int bmp280_common_probe(struct device *dev,
return dev_err_probe(dev, PTR_ERR(gpiod), "failed to get reset GPIO\n");
/* Deassert the signal */
- gpiod_set_value(gpiod, 0);
+ gpiod_set_value_cansleep(gpiod, 0);
data->regmap = regmap;
--
2.43.0
next prev parent reply other threads:[~2025-08-18 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 9:27 [PATCH v4 0/3] iio: pressure: bmp280: GPIO error handling and cleanups Salah Triki
2025-08-18 9:27 ` [PATCH v4 1/3] iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe() Salah Triki
2025-08-18 18:23 ` Jonathan Cameron
2025-08-20 14:48 ` Andy Shevchenko
2025-08-25 8:22 ` Jonathan Cameron
2025-08-18 9:27 ` [PATCH v4 2/3] iio: pressure: bmp280: Remove noisy dev_info() Salah Triki
2025-08-20 14:49 ` Andy Shevchenko
2025-09-13 14:22 ` Jonathan Cameron
2025-08-18 9:27 ` Salah Triki [this message]
2025-08-20 14:51 ` [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value_cansleep() Andy Shevchenko
2025-09-13 14:23 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818092740.545379-4-salah.triki@gmail.com \
--to=salah.triki@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®