mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Salah Triki <salah.triki@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	Markus.Elfring@web.de
Subject: Re: [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value_cansleep()
Date: Sat, 13 Sep 2025 15:23:51 +0100	[thread overview]
Message-ID: <20250913152351.4455efc2@jic23-huawei> (raw)
In-Reply-To: <aKXg6h0nW-GMcy1m@smile.fi.intel.com>

On Wed, 20 Aug 2025 17:51:22 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Aug 18, 2025 at 10:27:32AM +0100, Salah Triki wrote:
> > Switch to `gpiod_set_value_cansleep()`, which is safe to use in
> > sleepable contexts like the driver probe function.  
> 
> The commit message is unclear on why? aspect. You need to elaborate that some
> GPIO chips may be located behind slow (and hence sleepable) busses, such as
> I²C).
> 
> Code wise I agree with the change.
> With amended commit message
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 

I added a brief not on slow buses and applied.

Thanks,

Jonathan

      reply	other threads:[~2025-09-13 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  9:27 [PATCH v4 0/3] iio: pressure: bmp280: GPIO error handling and cleanups Salah Triki
2025-08-18  9:27 ` [PATCH v4 1/3] iio: pressure: bmp280: Use IS_ERR() in bmp280_common_probe() Salah Triki
2025-08-18 18:23   ` Jonathan Cameron
2025-08-20 14:48   ` Andy Shevchenko
2025-08-25  8:22     ` Jonathan Cameron
2025-08-18  9:27 ` [PATCH v4 2/3] iio: pressure: bmp280: Remove noisy dev_info() Salah Triki
2025-08-20 14:49   ` Andy Shevchenko
2025-09-13 14:22     ` Jonathan Cameron
2025-08-18  9:27 ` [PATCH v4 3/3] iio: pressure: bmp280: Use gpiod_set_value_cansleep() Salah Triki
2025-08-20 14:51   ` Andy Shevchenko
2025-09-13 14:23     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250913152351.4455efc2@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Markus.Elfring@web.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=salah.triki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®