* [PATCH] accel/rocket: Check the correct DMA irq status to warn about
@ 2025-08-18 18:56 Heiko Stuebner
2025-09-01 15:45 ` Tomeu Vizoso
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Stuebner @ 2025-08-18 18:56 UTC (permalink / raw)
To: tomeu; +Cc: ogabbay, dri-devel, linux-kernel, heiko
Right now, the code checks the DMA_READ_ERROR state 2 times, while
I guess it was supposed to warn about both read and write errors.
Change the 2nd check to look at the write-error flag.
Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/accel/rocket/rocket_job.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c
index 5d4afd692306..3440b862e749 100644
--- a/drivers/accel/rocket/rocket_job.c
+++ b/drivers/accel/rocket/rocket_job.c
@@ -422,7 +422,7 @@ static irqreturn_t rocket_job_irq_handler(int irq, void *data)
u32 raw_status = rocket_pc_readl(core, INTERRUPT_RAW_STATUS);
WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
- WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
+ WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_WRITE_ERROR);
if (!(raw_status & PC_INTERRUPT_RAW_STATUS_DPU_0 ||
raw_status & PC_INTERRUPT_RAW_STATUS_DPU_1))
--
2.47.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] accel/rocket: Check the correct DMA irq status to warn about
2025-08-18 18:56 [PATCH] accel/rocket: Check the correct DMA irq status to warn about Heiko Stuebner
@ 2025-09-01 15:45 ` Tomeu Vizoso
0 siblings, 0 replies; 2+ messages in thread
From: Tomeu Vizoso @ 2025-09-01 15:45 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: ogabbay, dri-devel, linux-kernel
On Mon, Aug 18, 2025 at 8:56 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Right now, the code checks the DMA_READ_ERROR state 2 times, while
> I guess it was supposed to warn about both read and write errors.
>
> Change the 2nd check to look at the write-error flag.
>
> Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Thanks, Heiko, you are right, I have applied it to drm-misc-next.
Regards,
Tomeu
> ---
> drivers/accel/rocket/rocket_job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c
> index 5d4afd692306..3440b862e749 100644
> --- a/drivers/accel/rocket/rocket_job.c
> +++ b/drivers/accel/rocket/rocket_job.c
> @@ -422,7 +422,7 @@ static irqreturn_t rocket_job_irq_handler(int irq, void *data)
> u32 raw_status = rocket_pc_readl(core, INTERRUPT_RAW_STATUS);
>
> WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
> - WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
> + WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_WRITE_ERROR);
>
> if (!(raw_status & PC_INTERRUPT_RAW_STATUS_DPU_0 ||
> raw_status & PC_INTERRUPT_RAW_STATUS_DPU_1))
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-01 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-18 18:56 [PATCH] accel/rocket: Check the correct DMA irq status to warn about Heiko Stuebner
2025-09-01 15:45 ` Tomeu Vizoso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®