From: "Rafael V. Volkmer" <rafael.v.volkmer@gmail.com>
To: rafael.v.volkmer@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
ukleinek@kernel.org
Subject: [PATCH v5 2/6] pwm: tiehrpwm: use FIELD_PREP()/FIELD_GET() for prescalers
Date: Fri, 22 Aug 2025 01:43:08 -0300 [thread overview]
Message-ID: <20250822044308.4052-1-rafael.v.volkmer@gmail.com> (raw)
In-Reply-To: <20250822044024.4015-1-rafael.v.volkmer@gmail.com>
Replace manual CLKDIV/HSPCLKDIV handling with GENMASK() and
FIELD_PREP()/FIELD_GET(). Introduce TBCTL_PRESCALE_MASK to update both
fields in a single ehrpwm_modify() call, and drop the unused SHIFT
macros.
This improves readability and lowers chances of off-by-shift errors.
No functional change intended.
Signed-off-by: Rafael V. Volkmer <rafael.v.volkmer@gmail.com>
---
drivers/pwm/pwm-tiehrpwm.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index 8509dd587..d140814a1 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -25,7 +25,9 @@
#define TBCTL_PRDLD_SHDW FIELD_PREP(TBCTL_PRDLD_MASK, 0)
#define TBCTL_PRDLD_IMDT FIELD_PREP(TBCTL_PRDLD_MASK, 1)
-#define TBCTL_CLKDIV_MASK GENMASK(12, 7)
+#define TBCTL_CLKDIV_MASK GENMASK(12, 10)
+#define TBCTL_HSPCLKDIV_MASK GENMASK(9, 7)
+#define TBCTL_PRESCALE_MASK (TBCTL_CLKDIV_MASK | TBCTL_HSPCLKDIV_MASK)
#define TBCTL_CTRMODE_MASK GENMASK(1, 0)
#define TBCTL_CTRMODE_UP FIELD_PREP(TBCTL_CTRMODE_MASK, 0)
@@ -33,9 +35,6 @@
#define TBCTL_CTRMODE_UPDOWN FIELD_PREP(TBCTL_CTRMODE_MASK, 2)
#define TBCTL_CTRMODE_FREEZE FIELD_PREP(TBCTL_CTRMODE_MASK, 3)
-#define TBCTL_HSPCLKDIV_SHIFT 7
-#define TBCTL_CLKDIV_SHIFT 10
-
#define CLKDIV_MAX 7
#define HSPCLKDIV_MAX 7
#define PERIOD_MAX 0xFFFF
@@ -173,8 +172,8 @@ static int set_prescale_div(unsigned long rqst_prescaler, u16 *prescale_div,
*prescale_div = (1 << clkdiv) *
(hspclkdiv ? (hspclkdiv * 2) : 1);
if (*prescale_div > rqst_prescaler) {
- *tb_clk_div = (clkdiv << TBCTL_CLKDIV_SHIFT) |
- (hspclkdiv << TBCTL_HSPCLKDIV_SHIFT);
+ *tb_clk_div = FIELD_PREP(TBCTL_CLKDIV_MASK, clkdiv) |
+ FIELD_PREP(TBCTL_HSPCLKDIV_MASK, hspclkdiv);
return 0;
}
}
@@ -280,7 +279,7 @@ static int ehrpwm_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
pm_runtime_get_sync(pwmchip_parent(chip));
/* Update clock prescaler values */
- ehrpwm_modify(pc->mmio_base, TBCTL, TBCTL_CLKDIV_MASK, tb_divval);
+ ehrpwm_modify(pc->mmio_base, TBCTL, TBCTL_PRESCALE_MASK, tb_divval);
/* Update period & duty cycle with presacler division */
period_cycles = period_cycles / ps_divval;
--
2.43.0
next prev parent reply other threads:[~2025-08-22 4:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 4:40 [PATCH v5 1/6] pwm: tiehrpwm: use GENMASK()/FIELD_PREP() for register fields Rafael V. Volkmer
2025-08-22 4:43 ` Rafael V. Volkmer [this message]
2025-08-22 4:45 ` [PATCH v5 3/6] pwm: tiehrpwm: refactor AQCTL macros Rafael V. Volkmer
2025-08-22 4:48 ` [PATCH v5 4/6] pwm: tiehrpwm: implement .get_state Rafael V. Volkmer
2025-08-22 4:50 ` [PATCH v5 5/6] pwm: tiehrpwm: account for active channels at probe Rafael V. Volkmer
2025-08-22 4:52 ` [PATCH v5 6/6] pwm: tiehrpwm: tidy prescale calculation style Rafael V. Volkmer
2025-08-25 8:27 ` [PATCH v5 1/6] pwm: tiehrpwm: use GENMASK()/FIELD_PREP() for register fields Uwe Kleine-König
2025-08-26 4:05 ` Rafael V. Volkmer
2025-09-12 9:57 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822044308.4052-1-rafael.v.volkmer@gmail.com \
--to=rafael.v.volkmer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®