From: Harini T <harini.t@amd.com>
To: <jassisinghbrar@gmail.com>, <michal.simek@amd.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <git@amd.com>,
Harini T <harini.t@amd.com>
Subject: [PATCH 2/3] mailbox: zynqmp-ipi: Fix out-of-bounds access in mailbox cleanup loop
Date: Fri, 22 Aug 2025 10:27:31 +0530 [thread overview]
Message-ID: <20250822045732.1068103-3-harini.t@amd.com> (raw)
In-Reply-To: <20250822045732.1068103-1-harini.t@amd.com>
Fix mailbox cleanup loop that accesses array out-of-bounds by starting
at num_boxes instead of numb_boxes-1 for 0-indexed arrays.
Signed-off-by: Harini T <harini.t@amd.com>
---
drivers/mailbox/zynqmp-ipi-mailbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index bdcc6937ee30..3b806d1f89bb 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -891,7 +891,7 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pdata *pdata)
xlnx_mbox_cleanup_sgi(pdata);
i = pdata->num_mboxes;
- for (; i >= 0; i--) {
+ for (i--; i >= 0; i--) {
ipi_mbox = &pdata->ipi_mboxes[i];
if (device_is_registered(&ipi_mbox->dev))
device_unregister(&ipi_mbox->dev);
--
2.43.0
next prev parent reply other threads:[~2025-08-22 4:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 4:57 [PATCH 0/3] mailbox: zynqmp-ipi: Improve resource cleanup on driver unbind Harini T
2025-08-22 4:57 ` [PATCH 1/3] mailbox: zynqmp-ipi: Remove redundant mbox_controller_unregister() call Harini T
2025-09-17 15:19 ` Peng Fan
2025-08-22 4:57 ` Harini T [this message]
2025-09-17 15:22 ` [PATCH 2/3] mailbox: zynqmp-ipi: Fix out-of-bounds access in mailbox cleanup loop Peng Fan
2025-08-22 4:57 ` [PATCH 3/3] mailbox: zynqmp-ipi: Fix SGI cleanup on unbind Harini T
2025-09-17 15:25 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822045732.1068103-3-harini.t@amd.com \
--to=harini.t@amd.com \
--cc=git@amd.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®