From: Peng Fan <peng.fan@oss.nxp.com>
To: Harini T <harini.t@amd.com>
Cc: jassisinghbrar@gmail.com, michal.simek@amd.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, git@amd.com
Subject: Re: [PATCH 3/3] mailbox: zynqmp-ipi: Fix SGI cleanup on unbind
Date: Wed, 17 Sep 2025 23:25:37 +0800 [thread overview]
Message-ID: <20250917152537.GE28673@nxa18884-linux.ap.freescale.net> (raw)
In-Reply-To: <20250822045732.1068103-4-harini.t@amd.com>
On Fri, Aug 22, 2025 at 10:27:32AM +0530, Harini T wrote:
>The driver incorrectly determines SGI vs SPI interrupts by checking IRQ
>number < 16, which fails with dynamic IRQ allocation. During unbind,
>this causes improper SGI cleanup leading to kernel crash.
>
>Add explicit irq_type field to pdata for reliable identification of SGI
>interrupts (type-2) and only clean up SGI resources when appropriate.
>
>Signed-off-by: Harini T <harini.t@amd.com>
Fixes tag?
Then Reviewed-by: Peng Fan <peng.fan@nxp.com>
prev parent reply other threads:[~2025-09-17 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 4:57 [PATCH 0/3] mailbox: zynqmp-ipi: Improve resource cleanup on driver unbind Harini T
2025-08-22 4:57 ` [PATCH 1/3] mailbox: zynqmp-ipi: Remove redundant mbox_controller_unregister() call Harini T
2025-09-17 15:19 ` Peng Fan
2025-08-22 4:57 ` [PATCH 2/3] mailbox: zynqmp-ipi: Fix out-of-bounds access in mailbox cleanup loop Harini T
2025-09-17 15:22 ` Peng Fan
2025-08-22 4:57 ` [PATCH 3/3] mailbox: zynqmp-ipi: Fix SGI cleanup on unbind Harini T
2025-09-17 15:25 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917152537.GE28673@nxa18884-linux.ap.freescale.net \
--to=peng.fan@oss.nxp.com \
--cc=git@amd.com \
--cc=harini.t@amd.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®