* [PATCH 1/3] kselftest/arm64: Remove extra blank line
2025-08-24 6:13 [PATCH 0/3] kselftest/arm64: Cleanups and readability fixes vivekyadav1207731111
@ 2025-08-24 6:14 ` vivekyadav1207731111
2025-08-24 6:14 ` [PATCH 2/3] kselftest/arm64: Supress warning and improve readability vivekyadav1207731111
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: vivekyadav1207731111 @ 2025-08-24 6:14 UTC (permalink / raw)
To: catalin.marinas, will, shuah, corbet
Cc: linux-arm-kernel, linux-kselftest, linux-kernel,
linux-kernel-mentees, linux-doc, Vivek Yadav
From: Vivek Yadav <vivekyadav1207731111@gmail.com>
Remove an unnecessary blank line to improve code style consistency.
```
[command]
./scripts/checkpatch.pl --strict -f <path/to/file>
[output]
CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary before a close brace '}'
```
Signed-off-by: Vivek Yadav <vivekyadav1207731111@gmail.com>
---
tools/testing/selftests/arm64/abi/hwcap.c | 1 -
tools/testing/selftests/arm64/bti/assembler.h | 1 -
tools/testing/selftests/arm64/fp/fp-ptrace.c | 1 -
tools/testing/selftests/arm64/fp/vec-syscfg.c | 1 -
tools/testing/selftests/arm64/fp/zt-ptrace.c | 1 -
tools/testing/selftests/arm64/gcs/gcs-locking.c | 1 -
6 files changed, 6 deletions(-)
diff --git a/tools/testing/selftests/arm64/abi/hwcap.c b/tools/testing/selftests/arm64/abi/hwcap.c
index 002ec38a8bbb..27d4790c2f0c 100644
--- a/tools/testing/selftests/arm64/abi/hwcap.c
+++ b/tools/testing/selftests/arm64/abi/hwcap.c
@@ -55,7 +55,6 @@ static void cmpbr_sigill(void)
/* Not implemented, too complicated and unreliable anyway */
}
-
static void crc32_sigill(void)
{
/* CRC32W W0, W0, W1 */
diff --git a/tools/testing/selftests/arm64/bti/assembler.h b/tools/testing/selftests/arm64/bti/assembler.h
index 04e7b72880ef..141cdcbf0b8f 100644
--- a/tools/testing/selftests/arm64/bti/assembler.h
+++ b/tools/testing/selftests/arm64/bti/assembler.h
@@ -14,7 +14,6 @@
#define GNU_PROPERTY_AARCH64_FEATURE_1_BTI (1U << 0)
#define GNU_PROPERTY_AARCH64_FEATURE_1_PAC (1U << 1)
-
.macro startfn name:req
.globl \name
\name:
diff --git a/tools/testing/selftests/arm64/fp/fp-ptrace.c b/tools/testing/selftests/arm64/fp/fp-ptrace.c
index 124bc883365e..3dc195f977ba 100644
--- a/tools/testing/selftests/arm64/fp/fp-ptrace.c
+++ b/tools/testing/selftests/arm64/fp/fp-ptrace.c
@@ -1569,7 +1569,6 @@ static void run_sve_tests(void)
&test_config);
}
}
-
}
static void run_sme_tests(void)
diff --git a/tools/testing/selftests/arm64/fp/vec-syscfg.c b/tools/testing/selftests/arm64/fp/vec-syscfg.c
index ea9c7d47790f..2d75d342eeb9 100644
--- a/tools/testing/selftests/arm64/fp/vec-syscfg.c
+++ b/tools/testing/selftests/arm64/fp/vec-syscfg.c
@@ -690,7 +690,6 @@ static inline void smstop(void)
asm volatile("msr S0_3_C4_C6_3, xzr");
}
-
/*
* Verify we can change the SVE vector length while SME is active and
* continue to use SME afterwards.
diff --git a/tools/testing/selftests/arm64/fp/zt-ptrace.c b/tools/testing/selftests/arm64/fp/zt-ptrace.c
index 584b8d59b7ea..a7f34040fbf1 100644
--- a/tools/testing/selftests/arm64/fp/zt-ptrace.c
+++ b/tools/testing/selftests/arm64/fp/zt-ptrace.c
@@ -108,7 +108,6 @@ static int get_zt(pid_t pid, char zt[ZT_SIG_REG_BYTES])
return ptrace(PTRACE_GETREGSET, pid, NT_ARM_ZT, &iov);
}
-
static int set_zt(pid_t pid, const char zt[ZT_SIG_REG_BYTES])
{
struct iovec iov;
diff --git a/tools/testing/selftests/arm64/gcs/gcs-locking.c b/tools/testing/selftests/arm64/gcs/gcs-locking.c
index 989f75a491b7..1e6abb136ffd 100644
--- a/tools/testing/selftests/arm64/gcs/gcs-locking.c
+++ b/tools/testing/selftests/arm64/gcs/gcs-locking.c
@@ -165,7 +165,6 @@ TEST_F(valid_modes, lock_enable_disable_others)
ASSERT_EQ(ret, 0);
ASSERT_EQ(mode, PR_SHADOW_STACK_ALL_MODES);
-
ret = my_syscall2(__NR_prctl, PR_SET_SHADOW_STACK_STATUS,
variant->mode);
ASSERT_EQ(ret, 0);
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/3] kselftest/arm64: Supress warning and improve readability
2025-08-24 6:13 [PATCH 0/3] kselftest/arm64: Cleanups and readability fixes vivekyadav1207731111
2025-08-24 6:14 ` [PATCH 1/3] kselftest/arm64: Remove extra blank line vivekyadav1207731111
@ 2025-08-24 6:14 ` vivekyadav1207731111
2025-08-24 6:14 ` [PATCH 3/3] kselftest/arm64: Add parentheses around sizeof for clarity vivekyadav1207731111
2025-09-08 15:55 ` [PATCH 0/3] kselftest/arm64: Cleanups and readability fixes Will Deacon
3 siblings, 0 replies; 6+ messages in thread
From: vivekyadav1207731111 @ 2025-08-24 6:14 UTC (permalink / raw)
To: catalin.marinas, will, shuah, corbet
Cc: linux-arm-kernel, linux-kselftest, linux-kernel,
linux-kernel-mentees, linux-doc, Vivek Yadav
From: Vivek Yadav <vivekyadav1207731111@gmail.com>
The comment was correct, but `checkpatch` script flagged it with a warning
as shown in the output section. The comment is slightly modified
to improve readability, which also suppresses the warning.
```
[command]
./script/checkpatch.pl --strict -f tools/testing/selftests/arm64/fp/fp-stress.c
[output]
WARNING: Possible repeated word: 'on'
```
Fixes: 98102a2cb7860 : kselftest/arm64: Hold fp-stress children until they're all spawned.
Signed-off-by: Vivek Yadav <vivekyadav1207731111@gmail.com>
---
tools/testing/selftests/arm64/fp/fp-stress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/arm64/fp/fp-stress.c b/tools/testing/selftests/arm64/fp/fp-stress.c
index 74e23208b94c..3a0ae96cf909 100644
--- a/tools/testing/selftests/arm64/fp/fp-stress.c
+++ b/tools/testing/selftests/arm64/fp/fp-stress.c
@@ -105,8 +105,8 @@ static void child_start(struct child_data *child, const char *program)
/*
* Read from the startup pipe, there should be no data
- * and we should block until it is closed. We just
- * carry on on error since this isn't super critical.
+ * and we should block until it is closed. We just
+ * carry-on on error since this isn't super critical.
*/
ret = read(3, &i, sizeof(i));
if (ret < 0)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] kselftest/arm64: Add parentheses around sizeof for clarity
2025-08-24 6:13 [PATCH 0/3] kselftest/arm64: Cleanups and readability fixes vivekyadav1207731111
2025-08-24 6:14 ` [PATCH 1/3] kselftest/arm64: Remove extra blank line vivekyadav1207731111
2025-08-24 6:14 ` [PATCH 2/3] kselftest/arm64: Supress warning and improve readability vivekyadav1207731111
@ 2025-08-24 6:14 ` vivekyadav1207731111
2025-09-08 15:55 ` [PATCH 0/3] kselftest/arm64: Cleanups and readability fixes Will Deacon
3 siblings, 0 replies; 6+ messages in thread
From: vivekyadav1207731111 @ 2025-08-24 6:14 UTC (permalink / raw)
To: catalin.marinas, will, shuah, corbet
Cc: linux-arm-kernel, linux-kselftest, linux-kernel,
linux-kernel-mentees, linux-doc, Vivek Yadav
From: Vivek Yadav <vivekyadav1207731111@gmail.com>
Added parentheses around sizeof to make the expression clearer
and improve readability. This change has no functional impact.
```
[command]
./scripts/checkpatch.pl tools/testing/selftests/arm64/fp/sve-ptrace.c
[output]
WARNING: sizeof *sve should be sizeof(*sve)
```
Fixes: 0dca276ac4d20 : selftests: arm64: Add test for the SVE ptrace interface
Signed-off-by: Vivek Yadav <vivekyadav1207731111@gmail.com>
---
tools/testing/selftests/arm64/fp/sve-ptrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/arm64/fp/sve-ptrace.c b/tools/testing/selftests/arm64/fp/sve-ptrace.c
index b22303778fb0..90c56b38dabf 100644
--- a/tools/testing/selftests/arm64/fp/sve-ptrace.c
+++ b/tools/testing/selftests/arm64/fp/sve-ptrace.c
@@ -115,7 +115,7 @@ static struct user_sve_header *get_sve(pid_t pid, const struct vec_type *type,
{
struct user_sve_header *sve;
void *p;
- size_t sz = sizeof *sve;
+ size_t sz = sizeof(*sve);
struct iovec iov;
while (1) {
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/3] kselftest/arm64: Cleanups and readability fixes
2025-08-24 6:13 [PATCH 0/3] kselftest/arm64: Cleanups and readability fixes vivekyadav1207731111
` (2 preceding siblings ...)
2025-08-24 6:14 ` [PATCH 3/3] kselftest/arm64: Add parentheses around sizeof for clarity vivekyadav1207731111
@ 2025-09-08 15:55 ` Will Deacon
3 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2025-09-08 15:55 UTC (permalink / raw)
To: catalin.marinas, shuah, corbet, vivekyadav1207731111
Cc: kernel-team, Will Deacon, linux-arm-kernel, linux-kselftest,
linux-kernel, linux-kernel-mentees, linux-doc
On Sat, 23 Aug 2025 23:13:59 -0700, vivekyadav1207731111@gmail.com wrote:
> This small series makes cosmetic style cleanups in the arm64 kselftests
> to improve readability and suppress checkpatch warnings. These changes
> are purely cosmetic and do not affect functionality.
>
> Changes in this series:
> * Suppress unnecessary checkpatch warning in a comment
> * Add parentheses around sizeof for clarity
> * Remove redundant blank line
>
> [...]
Applied to arm64 (for-next/selftests), thanks!
[1/3] kselftest/arm64: Remove extra blank line
https://git.kernel.org/arm64/c/3198780eaf37
[2/3] kselftest/arm64: Supress warning and improve readability
https://git.kernel.org/arm64/c/a940568ccde4
[3/3] kselftest/arm64: Add parentheses around sizeof for clarity
https://git.kernel.org/arm64/c/62e8a9fbaad1
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 6+ messages in thread