mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abinash Singh <abinashsinghlalotra@gmail.com>
To: bvanassche@acm.org
Cc: James.Bottomley@HansenPartnership.com,
	abinashsinghlalotra@gmail.com, dlemoal@kernel.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	martin.petersen@oracle.com
Subject: [PATCH v9 0/3] scsi: sd: Cleanups and warning fixes in sd_revalidate_disk()
Date: Sun, 24 Aug 2025 23:32:15 +0530	[thread overview]
Message-ID: <20250824180218.39498-1-abinashsinghlalotra@gmail.com> (raw)

Hi all,

Sorry for making mess in previous replies. My gmail app caused that.


This v9 series contains small cleanups and fixes in sd_revalidate_disk().

On Sat, Aug 23, 2025 at 1:17 AM Bart Van Assche wrote:
> From Documentation/process/coding-style.rst:
> These generic allocation functions all emit a stack dump on failure when
> used without __GFP_NOWARN so there is no use in emitting an additional
> failure message when NULL is returned.
>
> Has this example perhaps been followed? I think it is safe to remove
> this sd_printk() statement.

checkpatch.pl also emits the following warning for this code:
  WARNING: Possible unnecessary 'out of memory' message
  #52: FILE: drivers/scsi/sd.c:3716:
  + if (!lim) {
  +     sd_printk(KERN_WARNING, sdkp,

So I agree with Bart — this printk is redundant and should be removed.
In v9, I have split this into a separate patch for clarity.

Summary of changes in this series:
  Removed  the redundant 'out of memory' printk after kmalloc() failure in already existing code.
>     buffer = kmalloc(SD_BUF_SIZE, GFP_KERNEL);
>     if (!buffer) {
>              sd_printk(KERN_WARNING, sdkp, "sd_revalidate_disk: Memory "

  Added Bart Van Assche’s Reviewed-by tag in: [3/3] scsi: sd: make sd_revalidate_disk() return void

Changes since v8:
  - Split removal of the redundant printk into its own patch (1/3),
    instead of keeping it inside the warning fix.
  - Kept the build warning fix and return type change as separate patches.
  - Updated changelogs accordingly.

Thanks

Abinash

Abinash Singh (3):
  scsi: sd: Remove redundant printk after kmalloc failure
  scsi: sd: Fix build warning in sd_revalidate_disk()
  scsi: sd: make sd_revalidate_disk() return void

 drivers/scsi/sd.c | 58 ++++++++++++++++++++++++-----------------------
 1 file changed, 30 insertions(+), 28 deletions(-)

-- 
2.43.0


             reply	other threads:[~2025-08-24 18:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-24 18:02 Abinash Singh [this message]
2025-08-24 18:02 ` [PATCH v9 1/3] scsi: sd: Remove redundant printk after kmalloc failure Abinash Singh
2025-08-25  1:56   ` Damien Le Moal
2025-08-24 18:02 ` [PATCH v9 2/3] scsi: sd: Fix build warning in sd_revalidate_disk() Abinash Singh
2025-08-25  1:53   ` Damien Le Moal
2025-08-24 18:02 ` [PATCH v9 3/3] scsi: sd: make sd_revalidate_disk() return void Abinash Singh
2025-08-25  1:58   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250824180218.39498-1-abinashsinghlalotra@gmail.com \
    --to=abinashsinghlalotra@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bvanassche@acm.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®