* [PATCH v2] ethernet: tlan: Convert to use jiffies macro
@ 2025-08-25 10:41 zhang.enpei
2025-08-27 0:46 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: zhang.enpei @ 2025-08-25 10:41 UTC (permalink / raw)
To: chessman
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, netdev, linux-kernel
From: Zhang Enpei <zhang.enpei@zte.com.cn>
Use time_after_eq macro instead of using jiffies directly to handle
wraparound.
Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
---
drivers/net/ethernet/ti/tlan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index a55b0f951181..7c5e51284942 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -1817,7 +1817,6 @@ static void tlan_timer(struct timer_list *t)
{
struct tlan_priv *priv = timer_container_of(priv, t, timer);
struct net_device *dev = priv->dev;
- u32 elapsed;
unsigned long flags = 0;
priv->timer.function = NULL;
@@ -1844,8 +1843,7 @@ static void tlan_timer(struct timer_list *t)
case TLAN_TIMER_ACTIVITY:
spin_lock_irqsave(&priv->lock, flags);
if (priv->timer.function == NULL) {
- elapsed = jiffies - priv->timer_set_at;
- if (elapsed >= TLAN_TIMER_ACT_DELAY) {
+ if (time_is_before_eq_jiffies(priv->timer_set_at + TLAN_TIMER_ACT_DELAY)) {
tlan_dio_write8(dev->base_addr,
TLAN_LED_REG, TLAN_LED_LINK);
} else {
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ethernet: tlan: Convert to use jiffies macro
2025-08-25 10:41 [PATCH v2] ethernet: tlan: Convert to use jiffies macro zhang.enpei
@ 2025-08-27 0:46 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2025-08-27 0:46 UTC (permalink / raw)
To: zhang.enpei
Cc: chessman, andrew+netdev, davem, edumazet, pabeni, netdev, linux-kernel
On Mon, 25 Aug 2025 18:41:02 +0800 (CST) zhang.enpei@zte.com.cn wrote:
> From: Zhang Enpei <zhang.enpei@zte.com.cn>
>
> Use time_after_eq macro instead of using jiffies directly to handle
> wraparound.
Patch does not apply, looks like your email client or sever converted
tabs to spaces.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-27 0:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-25 10:41 [PATCH v2] ethernet: tlan: Convert to use jiffies macro zhang.enpei
2025-08-27 0:46 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®