mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Steven Rostedt <rostedt@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [for-next][PATCH 0/3] tracing: Trigger a warning on build if a tracepoint is defined but unused
Date: Fri, 29 Aug 2025 07:02:24 +1000	[thread overview]
Message-ID: <20250829070224.503ddc8a@canb.auug.org.au> (raw)
In-Reply-To: <20250828182754.733989525@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

Hi Steven,

On Thu, 28 Aug 2025 14:27:54 -0400 Steven Rostedt <rostedt@kernel.org> wrote:
>
> I built this against all archs in my tree (26 of them) with a allyesconfig.
> Unfortunately, only 10 build successfully with that (they all build
> successfully with defconfig and this option with tracing enabled). This
> detected 178 unique tracepoints that are defined and not used:
> 
> $ grep '^warning:' /work/autotest/cross-unused-traceevnts.log | sort -u |wc -l
> 178
> 
> Among them, 78 tracepoints were created and never referenced.
> 
> $ grep '^warning:' /work/autotest/cross-unused-traceevents.log | sort -u |cut -d"'" -f2 |
>     while read a ; do if ! git grep -q trace_$a ; then echo $a; fi ; done | wc -l
> 78
> 
> The 100 remaining are likely in strange #ifdef CONFIG combinations where an
> allyesconfig defines the tracepoint but doesn't enable the code that uses
> them.

[Pretending to be Linus :-)]

So, have you fixed up the 178 new warnings you know about?  I cannot
possibly do that, or even notify the offenders.  Please do that before
adding this code to linux-next.

But, really, these known warnings can just make it so much harder to
notice new ones.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2025-08-28 21:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 18:27 Steven Rostedt
2025-08-28 18:27 ` [for-next][PATCH 1/3] sorttable: Move ELF parsing into scripts/elf-parse.[ch] Steven Rostedt
2025-08-28 19:03   ` Nicolas Schier
2025-08-28 19:36     ` Steven Rostedt
2025-08-28 18:27 ` [for-next][PATCH 2/3] tracing: Add a tracepoint verification check at build time Steven Rostedt
2025-08-28 18:27 ` [for-next][PATCH 3/3] tracepoint: Do not warn for unused event that is exported Steven Rostedt
2025-08-28 21:02 ` Stephen Rothwell [this message]
2025-08-28 21:13   ` [for-next][PATCH 0/3] tracing: Trigger a warning on build if a tracepoint is defined but unused Steven Rostedt
2025-08-29 12:10   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250829070224.503ddc8a@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®