From: Steven Rostedt <rostedt@goodmis.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Steven Rostedt <rostedt@kernel.org>,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [for-next][PATCH 0/3] tracing: Trigger a warning on build if a tracepoint is defined but unused
Date: Fri, 29 Aug 2025 08:10:24 -0400 [thread overview]
Message-ID: <20250829081024.4a42e5be@gandalf.local.home> (raw)
In-Reply-To: <20250829070224.503ddc8a@canb.auug.org.au>
On Fri, 29 Aug 2025 07:02:24 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> But, really, these known warnings can just make it so much harder to
> notice new ones.
They all should be fixed. Note, this is not a compiler warning. It's a tool
that states "Your code is causing wasted memory to be allocate in the
running machine". If your tracepoint shows up in this list, then you should
fix it.
On an allyesconfig for x86_64:
warning: tracepoint 'kvm_iocsr' is unused.
warning: tracepoint 'nfs4_rename' is unused.
warning: tracepoint 'nfs4_renew' is unused.
warning: tracepoint 'xfs_metadir_link' is unused.
warning: tracepoint 'xfs_metadir_start_link' is unused.
warning: tracepoint 'xrep_rtbitmap_load_word' is unused.
warning: tracepoint 'xrep_rtbitmap_load_words' is unused.
warning: tracepoint 'xrep_rtbitmap_load' is unused.
warning: tracepoint 'xrep_nlinks_set_record' is unused.
warning: tracepoint 'xrep_cow_free_staging' is unused.
warning: tracepoint 'ocfs2_encode_fh_begin' is unused.
warning: tracepoint 'ocfs2_duplicate_clusters_by_jbd' is unused.
warning: tracepoint 'trans_restart_relock_key_cache_fill' is unused.
warning: tracepoint 'zonefs_file_dio_append' is unused.
warning: tracepoint 'edma_readb' is unused.
warning: tracepoint 'edma_readw' is unused.
warning: tracepoint 'host1x_syncpt_wait_check' is unused.
warning: tracepoint 'host1x_channel_submit_complete' is unused.
warning: tracepoint 'host1x_channel_release' is unused.
warning: tracepoint 'host1x_channel_open' is unused.
warning: tracepoint 'amdgpu_reset_reg_dumps' is unused.
warning: tracepoint 'amdgpu_dm_atomic_state_template' is unused.
warning: tracepoint 'xe_exec_queue_supress_resume' is unused.
warning: tracepoint 'xe_vm_restart' is unused.
warning: tracepoint 'xe_vma_userptr_rebind_exec' is unused.
warning: tracepoint 'xe_vma_userptr_rebind_worker' is unused.
warning: tracepoint 'xe_vma_flush' is unused.
warning: tracepoint 'dpu_rm_reserve_intf' is unused.
warning: tracepoint 'dpu_enc_atomic_check_flags' is unused.
warning: tracepoint 'dpu_crtc_runtime_resume' is unused.
warning: tracepoint 'dpu_enc_atomic_check' is unused.
warning: tracepoint 'dpu_trace_counter' is unused.
warning: tracepoint 'scsi_zone_wp_update' is unused.
warning: tracepoint 'scsi_prepare_zone_append' is unused.
warning: tracepoint 'ath12k_htt_rxdesc' is unused.
warning: tracepoint 'ath12k_htt_ppdu_stats' is unused.
warning: tracepoint 'ath12k_htt_pktlog' is unused.
warning: tracepoint 'brcms_dpc' is unused.
warning: tracepoint 'brcms_timer' is unused.
warning: tracepoint 'mt_tx_status' is unused.
warning: tracepoint 'ee_read' is unused.
warning: tracepoint 'cdns3_mapped_request' is unused.
warning: tracepoint 'cdns3_map_request' is unused.
warning: tracepoint 'cdns3_stream_transfer_split_next_part' is unused.
warning: tracepoint 'cdns3_stream_transfer_split' is unused.
warning: tracepoint 'cdnsp_handle_cmd_flush_ep' is unused.
warning: tracepoint 'cdnsp_setup_device' is unused.
warning: tracepoint 'cdnsp_free_priv_device' is unused.
warning: tracepoint 'cdnsp_defered_event' is unused.
warning: tracepoint 'cdnsp_ep0_halted' is unused.
warning: tracepoint 'cdns2_iso_out_ep_disable' is unused.
warning: tracepoint 'cdns2_mapped_request' is unused.
warning: tracepoint 'cdns2_map_request' is unused.
warning: tracepoint 'cdns2_ep0_enqueue' is unused.
warning: tracepoint 'cdns2_ep_queue' is unused.
warning: tracepoint 'cdns2_ep0_set_config' is unused.
warning: tracepoint 'cdns2_may_wakeup' is unused.
warning: tracepoint 'cdns2_lpm' is unused.
warning: tracepoint 'ucsi_reset_ppm' is unused.
warning: tracepoint 'ucsi_run_command' is unused.
warning: tracepoint 'icm_send_mra' is unused.
warning: tracepoint 'open_err_template' is unused.
warning: tracepoint 'irdma_send_cm_event_no_node' is unused.
warning: tracepoint 'hfi1_txq_xmit_stopped' is unused.
warning: tracepoint 'hfi1_mmu_invalidate' is unused.
warning: tracepoint 'rvt_mr_fmr_seg' is unused.
warning: tracepoint 'camera_debug' is unused.
warning: tracepoint 'camera_meminfo' is unused.
warning: tracepoint 'rpc_socket_reset_connection' is unused.
warning: tracepoint 'rxrpc_drop_ack' is unused.
warning: tracepoint 'cfg80211_return_u32' is unused.
warning: tracepoint 'cfg80211_return_uint' is unused.
warning: tracepoint 'cfg80211_chandef_dfs_required' is unused.
warning: tracepoint 'cfg80211_send_rx_auth' is unused.
warning: tracepoint 'rdev_return_void_tx_rx' is unused.
warning: tracepoint 'drv_offchannel_tx_cancel_wait' is unused.
warning: tracepoint 'tipc_node_dump' is unused.
warning: tracepoint '802154_new_scan_event' is unused.
warning: tracepoint '802154_drv_set_pan_coord' is unused.
Each one of those causes around 5K of wasted memory on your machine.
Most of them is because of some crazy config combinations the maintainer
has, as they are used, but for some reason an allyesconfig isn't the right
config option to enable them.
I'll push this branch up, and if it causes issues for you, I'll remove it.
But then, I'm not doing anymore work on fixing this.
-- Steve
prev parent reply other threads:[~2025-08-29 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 18:27 Steven Rostedt
2025-08-28 18:27 ` [for-next][PATCH 1/3] sorttable: Move ELF parsing into scripts/elf-parse.[ch] Steven Rostedt
2025-08-28 19:03 ` Nicolas Schier
2025-08-28 19:36 ` Steven Rostedt
2025-08-28 18:27 ` [for-next][PATCH 2/3] tracing: Add a tracepoint verification check at build time Steven Rostedt
2025-08-28 18:27 ` [for-next][PATCH 3/3] tracepoint: Do not warn for unused event that is exported Steven Rostedt
2025-08-28 21:02 ` [for-next][PATCH 0/3] tracing: Trigger a warning on build if a tracepoint is defined but unused Stephen Rothwell
2025-08-28 21:13 ` Steven Rostedt
2025-08-29 12:10 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829081024.4a42e5be@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®