From: Antheas Kapenekakis <lkml@antheas.dev>
To: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
philm@manjaro.org, "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"Antheas Kapenekakis" <lkml@antheas.dev>
Subject: [PATCH v3 3/6] drm: panel-backlight-quirks: Add secondary DMI match
Date: Fri, 29 Aug 2025 16:55:38 +0200 [thread overview]
Message-ID: <20250829145541.512671-4-lkml@antheas.dev> (raw)
In-Reply-To: <20250829145541.512671-1-lkml@antheas.dev>
Using a single DMI match only allows matching per manufacturer.
Introduce a second optional match to allow matching make/model.
In addition, make DMI optional to allow matching only by EDID.
Tested-by: Philip Müller <philm@manjaro.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/gpu/drm/drm_panel_backlight_quirks.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm/drm_panel_backlight_quirks.c
index 702726c20ccc..3d386a96e50e 100644
--- a/drivers/gpu/drm/drm_panel_backlight_quirks.c
+++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c
@@ -8,11 +8,14 @@
#include <drm/drm_edid.h>
#include <drm/drm_utils.h>
+struct drm_panel_match {
+ enum dmi_field field;
+ const char * const value;
+};
+
struct drm_get_panel_backlight_quirk {
- struct {
- enum dmi_field field;
- const char * const value;
- } dmi_match;
+ struct drm_panel_match dmi_match;
+ struct drm_panel_match dmi_match_other;
struct drm_edid_ident ident;
struct drm_panel_backlight_quirk quirk;
};
@@ -48,7 +51,13 @@ static bool drm_panel_min_backlight_quirk_matches(
const struct drm_get_panel_backlight_quirk *quirk,
const struct drm_edid *edid)
{
- if (!dmi_match(quirk->dmi_match.field, quirk->dmi_match.value))
+ if (quirk->dmi_match.field &&
+ !dmi_match(quirk->dmi_match.field, quirk->dmi_match.value))
+ return false;
+
+ if (quirk->dmi_match_other.field &&
+ !dmi_match(quirk->dmi_match_other.field,
+ quirk->dmi_match_other.value))
return false;
if (quirk->ident.panel_id && !drm_edid_match(edid, &quirk->ident))
--
2.51.0
next prev parent reply other threads:[~2025-08-29 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 14:55 [PATCH v3 0/6] drm: panel-backlight-quirks: Do partial refactor and apply OLED fix Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 1/6] drm: panel-backlight-quirks: Make EDID match optional Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 2/6] drm: panel-backlight-quirks: Convert brightness quirk to generic structure Antheas Kapenekakis
2025-08-29 14:55 ` Antheas Kapenekakis [this message]
2025-08-29 14:55 ` [PATCH v3 4/6] drm: panel-backlight-quirks: Add brightness mask quirk Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 5/6] drm: panel-backlight-quirks: Add Steam Deck brightness quirk Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirks Antheas Kapenekakis
2025-08-29 15:01 ` Antheas Kapenekakis
2025-09-03 4:52 ` Mario Limonciello
2025-09-03 15:03 ` Deucher, Alexander
2025-09-03 15:29 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829145541.512671-4-lkml@antheas.dev \
--to=lkml@antheas.dev \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bob.beckett@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=philm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®