From: Antheas Kapenekakis <lkml@antheas.dev>
To: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
philm@manjaro.org, "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"Antheas Kapenekakis" <lkml@antheas.dev>
Subject: [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirks
Date: Fri, 29 Aug 2025 16:55:41 +0200 [thread overview]
Message-ID: <20250829145541.512671-7-lkml@antheas.dev> (raw)
In-Reply-To: <20250829145541.512671-1-lkml@antheas.dev>
Currently, when a panel brightness quirk is applied, there is no log
indicating that a quirk was applied. Unwrap the drm device on its own
and use drm_info() to log when a quirk is applied.
Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 263f15f6fdea..2a3e17d83d6e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3617,13 +3617,15 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)
struct drm_connector *conn_base;
struct amdgpu_device *adev;
struct drm_luminance_range_info *luminance_range;
+ struct drm_device *drm;
if (aconnector->bl_idx == -1 ||
aconnector->dc_link->connector_signal != SIGNAL_TYPE_EDP)
return;
conn_base = &aconnector->base;
- adev = drm_to_adev(conn_base->dev);
+ drm = conn_base->dev;
+ adev = drm_to_adev(drm);
caps = &adev->dm.backlight_caps[aconnector->bl_idx];
caps->ext_caps = &aconnector->dc_link->dpcd_sink_ext_caps;
@@ -3659,12 +3661,20 @@ static void update_connector_ext_caps(struct amdgpu_dm_connector *aconnector)
panel_backlight_quirk =
drm_get_panel_backlight_quirk(aconnector->drm_edid);
if (!IS_ERR_OR_NULL(panel_backlight_quirk)) {
- if (panel_backlight_quirk->min_brightness)
+ if (panel_backlight_quirk->min_brightness) {
+ drm_info(drm,
+ "Applying panel backlight quirk, min_brightness: %d\n",
+ panel_backlight_quirk->min_brightness);
caps->min_input_signal =
panel_backlight_quirk->min_brightness - 1;
- if (panel_backlight_quirk->brightness_mask)
+ }
+ if (panel_backlight_quirk->brightness_mask) {
+ drm_info(drm,
+ "Applying panel backlight quirk, brightness_mask: 0x%X\n",
+ panel_backlight_quirk->brightness_mask);
caps->brightness_mask =
panel_backlight_quirk->brightness_mask;
+ }
}
}
--
2.51.0
next prev parent reply other threads:[~2025-08-29 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 14:55 [PATCH v3 0/6] drm: panel-backlight-quirks: Do partial refactor and apply OLED fix Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 1/6] drm: panel-backlight-quirks: Make EDID match optional Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 2/6] drm: panel-backlight-quirks: Convert brightness quirk to generic structure Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 3/6] drm: panel-backlight-quirks: Add secondary DMI match Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 4/6] drm: panel-backlight-quirks: Add brightness mask quirk Antheas Kapenekakis
2025-08-29 14:55 ` [PATCH v3 5/6] drm: panel-backlight-quirks: Add Steam Deck brightness quirk Antheas Kapenekakis
2025-08-29 14:55 ` Antheas Kapenekakis [this message]
2025-08-29 15:01 ` [PATCH v3 6/6] drm: panel-backlight-quirks: Log applied panel brightness quirks Antheas Kapenekakis
2025-09-03 4:52 ` Mario Limonciello
2025-09-03 15:03 ` Deucher, Alexander
2025-09-03 15:29 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829145541.512671-7-lkml@antheas.dev \
--to=lkml@antheas.dev \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bob.beckett@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=philm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®