From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: David Hildenbrand <david@redhat.com>
Cc: Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<dakr@kernel.org>, <dave@stgolabs.net>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>,
<marc.herbert@linux.intel.com>, <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/4] mm/memory_hotplug: Update comment for hotplug memory callback priorities
Date: Fri, 29 Aug 2025 15:11:16 +0100 [thread overview]
Message-ID: <20250829151116.00001144@huawei.com> (raw)
In-Reply-To: <14a0e842-8616-4bd3-8e11-7d8521c81cb0@redhat.com>
On Thu, 21 Aug 2025 23:17:38 +0200
David Hildenbrand <david@redhat.com> wrote:
> On 20.08.25 21:47, Dave Jiang wrote:
> > Add clarification to comment for memory hotplug callback ordering as the
> > current comment does not provide clear language on which callback happens
> > first.
> >
> > Acked-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > ---
> > v2:
> > - Clearer comment suggestion from DavidH.
> > ---
> > include/linux/memory.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/memory.h b/include/linux/memory.h
> > index 40eb70ccb09d..de5c0d8e8925 100644
> > --- a/include/linux/memory.h
> > +++ b/include/linux/memory.h
> > @@ -115,8 +115,8 @@ struct notifier_block;
> > struct mem_section;
> >
> > /*
> > - * Priorities for the hotplug memory callback routines (stored in decreasing
> > - * order in the callback chain)
> > + * Priorities for the hotplug memory callback routines. Invoked from
> > + * high to low. Higher priorities corresponds to higher numbers.
>
> Minor nit: s/corresponds/correspond/
With that tidied up
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>
next prev parent reply other threads:[~2025-08-29 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 19:47 [PATCH v2 0/4] cxl, acpi/hmat, node: Update CXL access coordinates to node directly Dave Jiang
2025-08-20 19:47 ` [PATCH v2 1/4] mm/memory_hotplug: Update comment for hotplug memory callback priorities Dave Jiang
2025-08-21 21:17 ` David Hildenbrand
2025-08-29 14:11 ` Jonathan Cameron [this message]
2025-08-20 19:47 ` [PATCH v2 2/4] drivers/base/node: Add a helper function node_update_perf_attrs() Dave Jiang
2025-08-20 19:47 ` [PATCH v2 3/4] cxl, acpi/hmat: Update CXL access coordinates directly instead of through HMAT Dave Jiang
2025-08-29 15:15 ` Jonathan Cameron
2025-08-20 19:47 ` [PATCH v2 4/4] acpi/hmat: Remove now unused hmat_update_target_coordinates() Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829151116.00001144@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=dakr@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.herbert@linux.intel.com \
--cc=rafael@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®