* [PATCH] gpio: fix GPIO submenu in Kconfig
@ 2025-09-01 12:55 Bartosz Golaszewski
2025-09-01 13:03 ` Arnd Bergmann
2025-09-02 9:30 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-09-01 12:55 UTC (permalink / raw)
To: Linus Walleij, Arnd Bergmann
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, Rob Herring
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Commit a86240a37d43 ("gpiolib: enable CONFIG_GPIOLIB_LEGACY even for
!GPIOLIB") accidentally pulled all items from within the GPIOLIB submenu
into the main driver menu. Put them back under the top-level GPIO entry.
Suggested-by: Rob Herring <robh@kernel.org>
Fixes: a86240a37d43 ("gpiolib: enable CONFIG_GPIOLIB_LEGACY even for !GPIOLIB")
Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/all/20250813222649.GA965895-robh@kernel.org/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index a437fe652dbc6..6fd904e29c3e7 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -3,6 +3,9 @@
# GPIO infrastructure and drivers
#
+config GPIOLIB_LEGACY
+ def_bool y
+
menuconfig GPIOLIB
bool "GPIO Support"
help
@@ -12,9 +15,6 @@ menuconfig GPIOLIB
If unsure, say N.
-config GPIOLIB_LEGACY
- def_bool y
-
if GPIOLIB
config GPIOLIB_FASTPATH_LIMIT
--
2.48.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: fix GPIO submenu in Kconfig
2025-09-01 12:55 [PATCH] gpio: fix GPIO submenu in Kconfig Bartosz Golaszewski
@ 2025-09-01 13:03 ` Arnd Bergmann
2025-09-02 9:30 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-09-01 13:03 UTC (permalink / raw)
To: Bartosz Golaszewski, Linus Walleij
Cc: open list:GPIO SUBSYSTEM, linux-kernel, Bartosz Golaszewski, Rob Herring
On Mon, Sep 1, 2025, at 14:55, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Commit a86240a37d43 ("gpiolib: enable CONFIG_GPIOLIB_LEGACY even for
> !GPIOLIB") accidentally pulled all items from within the GPIOLIB submenu
> into the main driver menu. Put them back under the top-level GPIO entry.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Fixes: a86240a37d43 ("gpiolib: enable CONFIG_GPIOLIB_LEGACY even for !GPIOLIB")
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/all/20250813222649.GA965895-robh@kernel.org/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I'm sorry I misunderstood the earlier bug report and assumed this
was already addressed. I now see what my mistake was and the fix looks
correct to me.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: fix GPIO submenu in Kconfig
2025-09-01 12:55 [PATCH] gpio: fix GPIO submenu in Kconfig Bartosz Golaszewski
2025-09-01 13:03 ` Arnd Bergmann
@ 2025-09-02 9:30 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-09-02 9:30 UTC (permalink / raw)
To: Linus Walleij, Arnd Bergmann, Bartosz Golaszewski
Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, Rob Herring
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Mon, 01 Sep 2025 14:55:13 +0200, Bartosz Golaszewski wrote:
> Commit a86240a37d43 ("gpiolib: enable CONFIG_GPIOLIB_LEGACY even for
> !GPIOLIB") accidentally pulled all items from within the GPIOLIB submenu
> into the main driver menu. Put them back under the top-level GPIO entry.
>
>
Applied, thanks!
[1/1] gpio: fix GPIO submenu in Kconfig
https://git.kernel.org/brgl/linux/c/ef9f21c3f370bcd45688a3a573b788e39b364e80
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-02 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-01 12:55 [PATCH] gpio: fix GPIO submenu in Kconfig Bartosz Golaszewski
2025-09-01 13:03 ` Arnd Bergmann
2025-09-02 9:30 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®