[PATCH v2] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios

[PATCH v2] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios

[Barnabás Czémán]

SD detection was not working because cd-gpios flag
was wrongly configured, according to downstream sources
device is using GPIO_ACTIVE_HIGH.
Fix SD detection with change cd-gpios from GPIO_ACTIVE_LOW
to GPIO_ACTIVE_HIGH.

Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for Xiaomi Mi A2 Lite")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
Changes in v2:
- Reword the commit.
- Link to v1: https://lore.kernel.org/r/20250830-daisy-sd-fix-v1-1-727e83a987b8@mainlining.org
---
 arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
index 336b916729e4721b5ba8f4f7e368d0d838aa54ab..ddd7af616794290aa1f06228a95cfa1d42b006e6 100644
--- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
+++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
@@ -296,7 +296,7 @@ &sdhc_2 {
 	vmmc-supply = <&pm8953_l11>;
 	vqmmc-supply = <&pm8953_l12>;
 
-	cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+	cd-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
 
 	pinctrl-names = "default", "sleep";
 	pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;

---
base-commit: 5d50cf9f7cf20a17ac469c20a2e07c29c1f6aab7
change-id: 20250830-daisy-sd-fix-011c23468e2a

Best regards,
-- 
Barnabás Czémán <barnabas.czeman@mainlining.org>

Re: [PATCH v2] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios

[Konrad Dybcio]

On 9/3/25 11:27 PM, Barnabás Czémán wrote:
> SD detection was not working because cd-gpios flag
> was wrongly configured, according to downstream sources
> device is using GPIO_ACTIVE_HIGH.
> Fix SD detection with change cd-gpios from GPIO_ACTIVE_LOW
> to GPIO_ACTIVE_HIGH.
> 
> Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for Xiaomi Mi A2 Lite")
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---

That's better, one can now reason that the change actually works and
is not only made to make the DT inline with downstream

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios

[Bjorn Andersson]

On Wed, 03 Sep 2025 23:27:33 +0200, Barnabás Czémán wrote:
> SD detection was not working because cd-gpios flag
> was wrongly configured, according to downstream sources
> device is using GPIO_ACTIVE_HIGH.
> Fix SD detection with change cd-gpios from GPIO_ACTIVE_LOW
> to GPIO_ACTIVE_HIGH.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios
      commit: 48e7e8996cf78101da5aa8292647ed960506da03

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>