mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Du, Bin" <bin.du@amd.com>
Cc: mchehab@kernel.org, hverkuil@xs4all.nl,
	bryan.odonoghue@linaro.org, sakari.ailus@linux.intel.com,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	sultan@kerneltoast.com, pratap.nirujogi@amd.com,
	benjamin.chan@amd.com, king.li@amd.com,
	gjorgji.rosikopulos@amd.com, Phil.Jawich@amd.com,
	Dominic.Antony@amd.com, mario.limonciello@amd.com,
	richard.gong@amd.com, anson.tsao@amd.com,
	Svetoslav Stoilov <Svetoslav.Stoilov@amd.com>
Subject: Re: [PATCH v3 1/7] media: platform: amd: Introduce amd isp4 capture driver
Date: Wed, 3 Sep 2025 09:51:52 +0200	[thread overview]
Message-ID: <20250903075152.GA13448@pendragon.ideasonboard.com> (raw)
In-Reply-To: <2464e531-6ef3-4d27-8053-5e4874a15b8c@amd.com>

On Wed, Sep 03, 2025 at 11:22:27AM +0800, Du, Bin wrote:
> Thanks Laurent Pinchart
> 
> On 9/2/2025 8:49 PM, Laurent Pinchart wrote:
> > Hi Bin,
> > 
> > Could you please provide the v4l2-compliance report (please use the
> > very latest version of v4l2-compliance), as well as the output of
> > `media-ctl -p -d /dev/media0` (replacing media0 with the appropriate
> > device) ?
> > 
> > Generally speaking, you should include a cover letter in patch series,
> > and that information can be included in the cover letter.
> > 
> 
> Yes, there is a cover letter for the patch series 
> https://lore.kernel.org/linux-media/20250828084507.94552-1-Bin.Du@amd.com/, 
> because of some server issue, the cover letter and left patches are sent 
> separately, really sorry for the confusing. It does contain 
> v4l2-compliance report, but the media-ctl output is missing, many thanks 
> for the guide, will include it either in the next patch

My bad, I even replied to that cover letter, but then forgot about it.

> > On Thu, Aug 28, 2025 at 06:08:05PM +0800, Bin Du wrote:
> >> AMD isp4 capture is a v4l2 media device which implements media controller
> >> interface. It has one sub-device (AMD ISP4 sub-device) endpoint which can
> >> be connected to a remote CSI2 TX endpoint. It supports only one physical
> >> interface for now. Also add ISP4 driver related entry info into the
> >> MAINTAINERS file
> >>
> >> Co-developed-by: Svetoslav Stoilov <Svetoslav.Stoilov@amd.com>
> >> Signed-off-by: Svetoslav Stoilov <Svetoslav.Stoilov@amd.com>
> >> Signed-off-by: Bin Du <Bin.Du@amd.com>
> >> ---
> >>   MAINTAINERS                              |  13 +++
> >>   drivers/media/platform/Kconfig           |   1 +
> >>   drivers/media/platform/Makefile          |   1 +
> >>   drivers/media/platform/amd/Kconfig       |   3 +
> >>   drivers/media/platform/amd/Makefile      |   3 +
> >>   drivers/media/platform/amd/isp4/Kconfig  |  13 +++
> >>   drivers/media/platform/amd/isp4/Makefile |   6 ++
> >>   drivers/media/platform/amd/isp4/isp4.c   | 121 +++++++++++++++++++++++
> >>   drivers/media/platform/amd/isp4/isp4.h   |  24 +++++
> >>   9 files changed, 185 insertions(+)
> >>   create mode 100644 drivers/media/platform/amd/Kconfig
> >>   create mode 100644 drivers/media/platform/amd/Makefile
> >>   create mode 100644 drivers/media/platform/amd/isp4/Kconfig
> >>   create mode 100644 drivers/media/platform/amd/isp4/Makefile
> >>   create mode 100644 drivers/media/platform/amd/isp4/isp4.c
> >>   create mode 100644 drivers/media/platform/amd/isp4/isp4.h

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2025-09-03  7:52 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 10:08 Bin Du
2025-08-28 10:08 ` [PATCH v3 2/7] media: platform: amd: low level support for isp4 firmware Bin Du
2025-08-28 10:08 ` [PATCH v3 3/7] media: platform: amd: Add isp4 fw and hw interface Bin Du
2025-08-28 10:08 ` [PATCH v3 4/7] media: platform: amd: isp4 subdev and firmware loading handling added Bin Du
2025-09-02  7:48   ` Markus Elfring
2025-09-05  6:35     ` Du, Bin
2025-09-03 10:10   ` Laurent Pinchart
2025-08-28 10:08 ` [PATCH v3 5/7] media: platform: amd: isp4 video node and buffers " Bin Du
2025-09-02  8:10   ` Markus Elfring
2025-09-02  9:16     ` Du, Bin
2025-09-03 10:08   ` Laurent Pinchart
2025-09-05  7:05     ` Du, Bin
2025-08-28 10:08 ` [PATCH v3 6/7] media: platform: amd: isp4 debug fs logging and more descriptive errors Bin Du
2025-08-28 10:08 ` [PATCH v3 7/7] Documentation: add documentation of AMD isp 4 driver Bin Du
2025-08-28 16:50   ` Mario Limonciello
2025-09-02  3:04     ` Du, Bin
2025-09-03 10:04   ` Laurent Pinchart
2025-09-03 10:34     ` Du, Bin
2025-08-28 16:54 ` [PATCH v3 1/7] media: platform: amd: Introduce amd isp4 capture driver Mario Limonciello
2025-09-02  3:11   ` Du, Bin
2025-09-02  6:48 ` Sakari Ailus
2025-09-02  7:58   ` Sakari Ailus
2025-09-02  9:09     ` Du, Bin
2025-09-02  7:06 ` Markus Elfring
2025-09-02  9:05   ` Du, Bin
2025-09-02 12:49 ` Laurent Pinchart
2025-09-03  3:22   ` Du, Bin
2025-09-03  7:51     ` Laurent Pinchart [this message]
2025-09-03  8:20       ` Du, Bin
2025-09-10 17:17 ` Mario Limonciello
2025-09-11  2:19   ` Du, Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903075152.GA13448@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=Dominic.Antony@amd.com \
    --cc=Phil.Jawich@amd.com \
    --cc=Svetoslav.Stoilov@amd.com \
    --cc=anson.tsao@amd.com \
    --cc=benjamin.chan@amd.com \
    --cc=bin.du@amd.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=gjorgji.rosikopulos@amd.com \
    --cc=hverkuil@xs4all.nl \
    --cc=king.li@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mchehab@kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=pratap.nirujogi@amd.com \
    --cc=richard.gong@amd.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sultan@kerneltoast.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®