Re: [PATCH v3 5/7] media: platform: amd: isp4 video node and buffers handling added

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Bin,

Thank you for the patch.

On Thu, Aug 28, 2025 at 06:08:09PM +0800, Bin Du wrote:
> Isp video implements v4l2 video interface and supports NV12 and YUYV. It
> manages buffers, pipeline power and state. Cherry-picked Sultan's DMA
> buffer realated fix from branch v6.16-drm-tip-isp4-for-amd on
> https://github.com/kerneltoast/kernel_x86_laptop.git
> 
> Co-developed-by: Sultan Alsawaf <sultan@kerneltoast.com>
> Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
> Co-developed-by: Svetoslav Stoilov <Svetoslav.Stoilov@amd.com>
> Signed-off-by: Svetoslav Stoilov <Svetoslav.Stoilov@amd.com>
> Signed-off-by: Bin Du <Bin.Du@amd.com>
> ---
>  MAINTAINERS                                   |    2 +
>  drivers/media/platform/amd/isp4/Makefile      |    1 +
>  drivers/media/platform/amd/isp4/isp4.c        |   10 +
>  drivers/media/platform/amd/isp4/isp4_subdev.c |   95 +-
>  drivers/media/platform/amd/isp4/isp4_subdev.h |    2 +
>  drivers/media/platform/amd/isp4/isp4_video.c  | 1213 +++++++++++++++++
>  drivers/media/platform/amd/isp4/isp4_video.h  |   87 ++
>  7 files changed, 1406 insertions(+), 4 deletions(-)
>  create mode 100644 drivers/media/platform/amd/isp4/isp4_video.c
>  create mode 100644 drivers/media/platform/amd/isp4/isp4_video.h

[snip]

> diff --git a/drivers/media/platform/amd/isp4/isp4_video.c b/drivers/media/platform/amd/isp4/isp4_video.c
> new file mode 100644
> index 000000000000..642faff83287
> --- /dev/null
> +++ b/drivers/media/platform/amd/isp4/isp4_video.c

[snip]

> +static int isp4vid_ioctl_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
> +{
> +	struct isp4vid_dev *isp_vdev = video_drvdata(file);
> +
> +	strscpy(cap->driver, ISP4VID_ISP_DRV_NAME, sizeof(cap->driver));
> +	snprintf(cap->card, sizeof(cap->card), "%s", ISP4VID_ISP_DRV_NAME);
> +	snprintf(cap->bus_info, sizeof(cap->bus_info),
> +		 "platform:%s", ISP4VID_ISP_DRV_NAME);

The bus_info is set by v4l_quercap, I think you can drop it here (please
double-check the result).

> +
> +	cap->capabilities |= (V4L2_CAP_STREAMING |
> +			      V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_IO_MC);

You can now drop V4L2_CAP_IO_MC (and there's no need for parentheses).

> +
> +	dev_dbg(isp_vdev->dev, "%s|capabilities=0x%X",
> +		isp_vdev->vdev.name, cap->capabilities);
> +
> +	return 0;
> +}

[snip]

-- 
Regards,

Laurent Pinchart