* [PATCH] crypto: rockchip - Fix dma_unmap_sg() nents value
@ 2025-09-03 8:06 Thomas Fourier
2025-09-13 4:26 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Fourier @ 2025-09-03 8:06 UTC (permalink / raw)
Cc: Thomas Fourier, stable, Corentin Labbe, Herbert Xu,
David S. Miller, Heiko Stuebner, John Keeping, linux-crypto,
linux-arm-kernel, linux-rockchip, linux-kernel
The dma_unmap_sg() functions should be called with the same nents as the
dma_map_sg(), not the value the map function returned.
Fixes: 57d67c6e8219 ("crypto: rockchip - rework by using crypto_engine")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto/rockchip/rk3288_crypto_ahash.c
index d6928ebe9526..b9f5a8b42e66 100644
--- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c
+++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c
@@ -254,7 +254,7 @@ static void rk_hash_unprepare(struct crypto_engine *engine, void *breq)
struct rk_ahash_rctx *rctx = ahash_request_ctx(areq);
struct rk_crypto_info *rkc = rctx->dev;
- dma_unmap_sg(rkc->dev, areq->src, rctx->nrsg, DMA_TO_DEVICE);
+ dma_unmap_sg(rkc->dev, areq->src, sg_nents(areq->src), DMA_TO_DEVICE);
}
static int rk_hash_run(struct crypto_engine *engine, void *breq)
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: rockchip - Fix dma_unmap_sg() nents value
2025-09-03 8:06 [PATCH] crypto: rockchip - Fix dma_unmap_sg() nents value Thomas Fourier
@ 2025-09-13 4:26 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2025-09-13 4:26 UTC (permalink / raw)
To: Thomas Fourier
Cc: stable, Corentin Labbe, David S. Miller, Heiko Stuebner,
John Keeping, linux-crypto, linux-arm-kernel, linux-rockchip,
linux-kernel
On Wed, Sep 03, 2025 at 10:06:46AM +0200, Thomas Fourier wrote:
> The dma_unmap_sg() functions should be called with the same nents as the
> dma_map_sg(), not the value the map function returned.
>
> Fixes: 57d67c6e8219 ("crypto: rockchip - rework by using crypto_engine")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
> ---
> drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-13 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-03 8:06 [PATCH] crypto: rockchip - Fix dma_unmap_sg() nents value Thomas Fourier
2025-09-13 4:26 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®